Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDRS: Move preconditioning #302

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Conversation

h-larsson
Copy link
Contributor

The location of the preconditioner did not seem right. According to [1], it should be applied after v = r - G c.
Currently, the preconditioner is only applied to G c

[1] ACM Trans. Math. Software,, Vol. 38, No. 1, pp. 5:1-5:19, 2011, Fig 23

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1383627942

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 96.234%

Totals Coverage Status
Change from base Build 888541031: -1.3%
Covered Lines: 1712
Relevant Lines: 1779

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 26, 2021

Pull Request Test Coverage Report for Build 1386804732

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.525%

Totals Coverage Status
Change from base Build 888541031: 0.0%
Covered Lines: 1734
Relevant Lines: 1778

💛 - Coveralls

@mschauer
Copy link
Member

Thanks for catching that. Would be nice if we can add a test showing that the preconditioner works now

@mschauer
Copy link
Member

@mschauer
Copy link
Member

h-larsson#1 (please merge into your branch) sharpens the tests, in a way that they will fail with the wrong order and pass with your right order. CC @deltaeecs

@mschauer mschauer merged commit 6af7d5e into JuliaLinearAlgebra:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants