Adding preconditioner to idrs

[deltaeecs]

Here I added Pl preconditioner to idrs add tested it with IncompleteLU preconditioner.

[mschauer]

Nice! Did you follow literature or is it just clear how to add the preconditioner here? Pinging @astudillor, can you also have a cursory look?

[mschauer]

I think you never use precT, so you don't need that type parameter in the method signature

[deltaeecs]

Yes, I just followed the "gmres.jl" and added "precT". Maybe it will be useful in the future?

[mschauer]

We have a file for test dependencies, https://github.com/JuliaLinearAlgebra/IterativeSolvers.jl/blob/master/test/Project.toml, we only need that dependency for the test, right?

[deltaeecs]

I just checked the "gmres.jl" and found it use LU instead of the IncompleteLU I added in the dependency，shall I removed it?

[mschauer]

It makes sense to have a non-exact preconditioner in the test, or? Perhaps just move the

IncompleteLU = "40713840-3770-5561-ab4c-a76e7d0d7895"

line to https://github.com/JuliaLinearAlgebra/IterativeSolvers.jl/blob/master/test/Project.toml

[deltaeecs]

ok

[deltaeecs]

Nice! Did you follow literature or is it just clear how to add the preconditioner here? Pinging @astudillor, can you also have a cursory look?

hahaha
I followed the Matlab Code referred in the docs because I found idrs performs better than gmres in my work~

[mschauer]

Haha, you can also compare with https://github.com/astudillor/idrs/blob/master/idrs/idrs.py

[deltaeecs]

Haha, you can also compare with https://github.com/astudillor/idrs/blob/master/idrs/idrs.py

Thank you for your help~
I think they are the same after checked the idrs.py~
I'm so happy since it's my first time to do a little work on git~

[mschauer]

Great. Can I ask on what type of problem you are working such that IDR(s) beats GMRES?

[deltaeecs]

Great. Can I ask on what type of problem you are working such that IDR(s) beats GMRES?

It's a badly conditioned matrix equation on Computational Electromagneticcalled EFIE~

[coveralls]

Pull Request Test Coverage Report for Build 842243156

• 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-1.2%) to 96.29%

---

Totals
Change from base Build 669197700:	-1.2%
Covered Lines:	1713
Relevant Lines:	1779

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 842243156

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 97.776%

---

Totals
Change from base Build 669197700:	0.3%
Covered Lines:	1934
Relevant Lines:	1978

---

💛 - Coveralls

[deltaeecs]

Great. Can I ask on what type of problem you are working such that IDR(s) beats GMRES?

It's a badly conditioned matrix equation on Computational Electromagneticcalled EFIE~

Well it seems to be a problem of problem of setting on preconditioner. GMRES remains the best solver after I corrected it.

[mschauer]

Ref #302