Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote Win32 back to tier 1 #1771

Merged
merged 1 commit into from
Jan 21, 2023
Merged

promote Win32 back to tier 1 #1771

merged 1 commit into from
Jan 21, 2023

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Nov 1, 2022

We have not had CI issues in a fairly long time1, and we do expect it to work and be tested at all times still.

Footnotes

  1. https://github.com/JuliaLang/www.julialang.org/commit/55ff318eec7e09e269a3229508e6621f14f9d004

We have not had CI issues in a fairly long time[^1], and we do expect
it to work and be tested at all times still.

[^1]: 55ff318
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR1771/ in ~15 minutes

@KristofferC
Copy link
Member

CI for windows on 1.8 is borken: JuliaLang/julia#46984

@vtjnash
Copy link
Member Author

vtjnash commented Nov 1, 2022

That is JuliaLang/julia#46940

@KristofferC
Copy link
Member

Is that really on the 1.8 branch?

@vtjnash
Copy link
Member Author

vtjnash commented Nov 1, 2022

No, that is on master (and i686-linux-gnu), and indeed, also needs to reapply a PR to reproduce the issue. But it appears to be the same, although we were not running win32 CI on buildkite yet at the time of that failure for comparison.

@DilumAluthge
Copy link
Member

This shouldn't be merged until JuliaCI/julia-buildkite#226 has been merged.

@KristofferC
Copy link
Member

Just pointing out, that the one who bumps a platform to tier 1 is also signing up to fix any issue that occurs in the future that is unique to that platform :).

@ViralBShah
Copy link
Member

I feel it is best to leave it at Tier 2...

@vtjnash
Copy link
Member Author

vtjnash commented Jan 21, 2023

It passes as much as other tier 1 platforms (Win64 + linux32), since it shares pretty much all code and issues with one of those 2. We can demote it again just as easily if that ceases to be true.

@vtjnash vtjnash merged commit ec9d670 into main Jan 21, 2023
@vtjnash vtjnash deleted the jn/win32-tier1 branch January 21, 2023 04:58
@KristofferC
Copy link
Member

We can demote it again just as easily if that ceases to be true.

What? A tier is not a reflection of the current state of CI. It is a commitment saying that if CI drifts away from what the tier list states then we will not do a release until CI has been fixed.

@ViralBShah
Copy link
Member

I don't think it is a good idea to promote win32 up again. See-sawing it up and down the tiers is not a good look.

@vtjnash
Copy link
Member Author

vtjnash commented Jan 22, 2023

We can revert. I just didn't want this to conflict with the Win8 PR. And I do think it is fairly stable on CI and still useful to make releases for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants