Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Move x86_64-w64-mingw32 and i686-w64-mingw32 from "allow fail" to "regular" #226

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

DilumAluthge
Copy link
Member

Needs JuliaLang/julia#47404 to be merged first.

@DilumAluthge DilumAluthge added DO NOT MERGE Do not merge this PR! and removed DO NOT MERGE Do not merge this PR! labels Oct 31, 2022
@DilumAluthge DilumAluthge marked this pull request as ready for review November 2, 2022 00:12
@DilumAluthge DilumAluthge marked this pull request as draft November 2, 2022 00:15
@DilumAluthge DilumAluthge added the DO NOT MERGE Do not merge this PR! label Nov 2, 2022
@vtjnash
Copy link
Member

vtjnash commented Nov 2, 2022

JuliaLang/julia#47406 is now merged

@DilumAluthge
Copy link
Member Author

I just need to remove some extraneous changes from this PR, and then we'll be good to go.

@DilumAluthge DilumAluthge changed the title Move Windows from "allow fail" to "regular" Move x86_64-w64-mingw32 and i686-w64-mingw32 from "allow fail" to "regular" Nov 2, 2022
@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Nov 2, 2022
@DilumAluthge DilumAluthge marked this pull request as ready for review November 2, 2022 06:42
@DilumAluthge DilumAluthge changed the title Move x86_64-w64-mingw32 and i686-w64-mingw32 from "allow fail" to "regular" Windows: Move x86_64-w64-mingw32 and i686-w64-mingw32 from "allow fail" to "regular" Nov 2, 2022
@DilumAluthge DilumAluthge marked this pull request as draft November 2, 2022 07:34
@DilumAluthge DilumAluthge marked this pull request as ready for review November 2, 2022 08:08
@DilumAluthge DilumAluthge merged commit 32448a3 into main Nov 2, 2022
@DilumAluthge DilumAluthge deleted the dpa/windows branch November 2, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants