Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Float16 to supported x86 processors (#46499) #52244

Conversation

BioTurboNick
Copy link
Contributor

Reopening #51700

@vchuravy vchuravy requested review from maleadt and gbaraldi November 20, 2023 20:48
@rbvermaa
Copy link
Contributor

rbvermaa commented Nov 21, 2023

There still seem to be an issue with Float16 on this branch:

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.9.3 (2023-10-14)
 _/ |\__'_|_|_|\__'_|  |  float16-sapphirerapids/a639fab579 (fork: 3196 commits, 788 days)
|__/                   |

julia> Float16(2.0)
Float16(0.0)

julia> versioninfo()
Julia Version 1.9.3
Commit a639fab579 (2023-10-14 13:38 UTC)
Platform Info:
  OS: Linux (x86_64-unknown-linux-gnu)
  CPU: 8 × Intel(R) Xeon(R) Platinum 8488C
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, sapphirerapids)
  Threads: 1 on 8 virtual cores
Environment:
  LD_FOR_TARGET = ld

This was run on a r7i instance on EC2

* Add float16 multiversioning for x86

Co-authored-by: pchintalapudi <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
@JeffBezanson JeffBezanson force-pushed the float16-sapphirerapids branch from a639fab to ecfa903 Compare November 21, 2023 17:05
@vchuravy
Copy link
Member

vchuravy commented Nov 21, 2023

Could you test if backporting #51666 fixes that?

As Tim said in the PR, that's not backportable.

@fingolfin
Copy link
Member

What's the status of this PR? Is the issue @rbvermaa reported still there? Is anyone working on it?

@BioTurboNick
Copy link
Contributor Author

BioTurboNick commented Feb 15, 2024

As far as I understand it, a solution pretty much has been identified - Float16 instructions probably need to be turned off on Sapphire Rapids with 1.9. So I think we should look for that to be done once the devs prioritize the next point release of 1.9.

See comment: #51482 (comment) I confirmed that it fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants