Properly detect Float16 support on Sapphire Rapids on 1.9 #51700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd have been better to at least cherry pick ee82caa (from #46499) to retain authorship and also add the appropriate test. I'm also not entirely sure whether backporting a new feature is a good idea. @KristofferC? |
|
Fair, I'm just not familiar with doing that operation. - Done Is it really considered a new feature, or fixing an oversight? |
* Add float16 multiversioning for x86 Co-authored-by: pchintalapudi <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
BioTurboNick
force-pushed
the
float16-sapphirerapids
branch
from
03274a0 to
a639fab
Compare
|
That commit alone was enough to address #51686 and have the tests fully pass. CSV.jl precompilation still seems to be more elusive. |
KristofferC
force-pushed
the
backports-release-1.9
branch
2 times, most recently
from
4f07359 to
926a060
Compare
|
Can you reopen the PR? I think you need to target release-1.9 |
|
I do not have the option to reopen unfortunately |
|
Click on the "create pull request" button in release-1.9...BioTurboNick:julia:float16-sapphirerapids |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51686
Interestingly, only one
float16Base test failed on 1.9.3:string(reinterpret(Float16, 0x7bff)) == "6.55e4", throwing aBoundsError. But it passes with this PR.Does not fix #51482 however.