New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for async backtraces of Tasks on any thread #51430

Merged

vtjnash merged 2 commits into master from jn/async-stacktrace

Sep 25, 2023

Member

vtjnash commented Sep 22, 2023

No description provided.

vtjnash added multithreading feature labels

vtjnash requested a review from JeffBezanson

September 22, 2023 21:23

kpamnany mentioned this pull request

Improve jl_print_task_backtraces() #50968

Closed


          add support for async backtraces of Tasks on any thread

1d9ebbc

vtjnash force-pushed the jn/async-stacktrace branch from 63f43ba to f662a2e Compare

September 24, 2023 13:46


          deal with remaining race conditions in these APIs

f7d8bfb

The jl_live_tasks API now reports all threads, instead of only Tasks
first started by the current thread. There is a new abstraction called
mtarraylist with adds functionality to small_arraylist (it is
layout-compatible). In particular, it makes it safe for another thread
to observe the content of the list concurrently with any mutations.

vtjnash force-pushed the jn/async-stacktrace branch from f662a2e to f7d8bfb Compare

September 24, 2023 17:29

vtjnash merged commit e5c6340 into master

1 check passed

vtjnash deleted the jn/async-stacktrace branch

September 25, 2023 11:20

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

99def4c

kpamnany mentioned this pull request

Backport support for async backtraces RelationalAI/julia#72

Merged

2 tasks

Contributor

kpamnany commented Sep 25, 2023

What this PR does (for future reference):

Previously, the C/C++ part of the runtime had only arraylist_t and small_arraylist_t for lists of things, neither of which are inherently thread-safe and need an external lock.

This PR adds small_mtarraylist_t which is basically a small_arraylist_t with atomics that allows multiple threads to safely read pushes and adds (which have implicit resizes when necessary) concurrently with a single writer thread.

Three lists in ptls->heap are converted to small_mtarraylist_ts -- weak_refs, live_tasks and free_stacks and the code that touches these has been updated to use the new thread-safe accessors.

Then, jl_live_tasks() is also updated and, it looks like, hardened somewhat to handle foreign threads and GC threads correctly.

There are some changes to the signal_listener and jl_thread_suspend_and_get_state and jl_thread_resume that I think are used by the profiling mechanism but I'm not very clear on what's going on there.

All that essentially enables: jl_rec_backtrace() is improved to not simply skip over sticky tasks or tasks running on other threads; it now uses jl_thread_suspend_and_get_state to stop the thread and get its state (which includes the backtrace). And jl_print_task_backtraces() is updated to use the correct (small_mtarraylist_t) calls to access live_tasks.

kpamnany mentioned this pull request

jl_print_task_backtraces() is missing some tasks #47928

Closed

Member

oscardssmith commented Sep 25, 2023

what's the difference between an arraylist_t and a Julia Vector (which we can also use from the C side?

Member Author

vtjnash commented Sep 26, 2023

An arraylist_t is not a safepoint, and as such, cannot hold GC references and cannot be reclaimed by the GC. In most cases, Vector{Int} is the preferable thing to use, if the GC is available and initialized on that thread.

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

145079c

kpamnany mentioned this pull request

Fix segfault if root task is NULL #51471

Merged

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

348e02e

vtjnash pushed a commit that referenced this pull request


          Fix segfault if root task is NULL (#51471)

cde964f

In `jl_print_task_backtraces()`. Follow-on to
#51430.

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

f9b9599

kpamnany added a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

5959ae2

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

0f64694

kpamnany added a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

0a9a31c

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

Contributor

kpamnany commented Oct 19, 2023

The previous implementation of this capability was insufficiently safe and segfaults on occasion, so this is actually a bugfix. Can we backport it to 1.10 @vtjnash and @KristofferC?

Contributor

kpamnany commented Oct 19, 2023

If so, #51471 should be backported also.

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

fdd81c3

kpamnany added a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

7818e1b

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

kpamnany added the backport 1.10 label

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

4b3da0e

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

71b4c7d

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

958364e

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

df89da8

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

3bcf8ce

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

86f80b0

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

KristofferC mentioned this pull request

Backports for 1.10.0-rc2 #52045

Merged

39 tasks

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

061ec10

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

2fef88c

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

ab20a69

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

9f59b7b

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

efdafaf

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

acf11c1

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

621bc9f

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

1fea881

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

db4cec8

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

e4fc64e

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

550f865

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

5c526e5

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

f04ba29

DelveCI pushed a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

905e4e9

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

kpamnany pushed a commit to RelationalAI/julia that referenced this pull request


          add support for async backtraces of Tasks on any thread (JuliaLang#51430

197b7d8

kpamnany added a commit to RelationalAI/julia that referenced this pull request


          Fix segfault if root task is NULL (JuliaLang#51471)

12508d8

In `jl_print_task_backtraces()`. Follow-on to
JuliaLang#51430.

KristofferC pushed a commit that referenced this pull request


          add support for async backtraces of Tasks on any thread (#51430)

e4ad8ab

(cherry picked from commit e5c6340)

KristofferC pushed a commit that referenced this pull request


          Fix segfault if root task is NULL (#51471)

4120fd8

In `jl_print_task_backtraces()`. Follow-on to
#51430.

(cherry picked from commit cde964f)

KristofferC pushed a commit that referenced this pull request


          add support for async backtraces of Tasks on any thread (#51430)

4f7feb1

(cherry picked from commit e5c6340)

KristofferC pushed a commit that referenced this pull request


          Fix segfault if root task is NULL (#51471)

a16e4e1

In `jl_print_task_backtraces()`. Follow-on to
#51430.

(cherry picked from commit cde964f)

KristofferC added a commit that referenced this pull request


          Backports for 1.10.0-rc2 (#52045)

d9da975

Backported PRs:
- [x] #51213 <!-- Wait for other threads to finish compiling before
exiting -->
- [x] #51520 <!-- Make allocopt respect the GC verifier rules with non
usual address spaces -->
- [x] #51598 <!-- Use a simple error when reporting sysimg load
failures. -->
- [x] #51757 <!-- fix parallel peakflop usage -->
- [x] #51781 <!-- Don't make pkgimages global editable -->
- [x] #51848 <!-- allow finalizers to take any locks and yield during
exit -->
- [x] #51847 <!-- add missing wait during Timer and AsyncCondition close
-->
- [x] #50824 <!-- Add some aliasing warnings to docstrings for mutating
functions in Base -->
- [x] #51885 <!-- remove chmodding the pkgimages -->
- [x] #50207 <!-- [devdocs] Improve documentation about building
external forks of LLVM -->
- [x] #51967 <!-- further fix to the new promoting method for
AbstractDateTime subtraction -->
- [x] #51980 <!-- macroexpand: handle const/atomic struct fields
correctly -->
- [x] #51995 <!-- [Artifacts] Pass artifacts dictionary to
`ensure_artifact_installed` dispatch -->
- [x] #52098 <!-- Fix errors in `sort` docstring -->
- [x] #52136 <!-- Bump JuliaSyntax to 0.4.7 -->
- [x] #52140 <!-- Make c func `abspath` consistent on Windows. Fix
tracking path conversion. -->
- [x] #52009 <!-- fix completion that resulted in startpos of 0 for `\\
-->
- [x] #52192 <!-- cap the number of GC threads to number of cpu cores
-->
- [x] #52206 <!-- Make have_fma consistent between interpreter and
compiled -->
- [x] #52027 <!-- fix Unicode.julia_chartransform for Julia 1.10 -->
- [x] #52217 <!-- More helpful error message for empty `cpu_target` in
`Base.julia_cmd` -->
- [x] #51371 <!-- Memoize `cwstring` when used for env lookup /
modification on Windows -->
- [x] #52214 <!-- Turn Method Overwritten Error into a PrecompileError
-- turning off caching -->
- [x] #51895 <!-- Devdocs on fixing precompile hangs, take 2 -->
- [x] #51596 <!-- Reland "Don't mark nonlocal symbols as hidden"" -->
- [x] #51834 <!-- [REPLCompletions] allow symbol completions within
incomplete macrocall expression -->
- [x] #52010 <!-- Revert "Support sorting iterators (#46104)" -->
- [x] #51430 <!-- add support for async backtraces of Tasks on any
thread -->
- [x] #51471 <!-- Fix segfault if root task is NULL -->
- [x] #52194 <!-- Fix multiversioning issues caused by the parallel llvm
work -->
- [x] #51035 <!-- refactor GC scanning code to reflect jl_binding_t are
now first class -->
- [x] #52030 <!-- Bump Statistics -->
- [x] #52189 <!-- codegen: ensure i1 bool is widened to i8 before
storing -->
- [x] #52228 <!-- Widen diagonal var during `Type` unwrapping in
`instanceof_tfunc` -->
- [x] #52182 <!-- jitlayers: replace sharedbytes intern pool with one
that respects alignment -->

Contains multiple commits, manual intervention needed:
- [ ] #51092 <!-- inference: fix bad effects for recursion -->

Non-merged PRs with backport label:
- [ ] #52196 <!-- Fix creating custom log level macros -->
- [ ] #52170 <!-- fix invalidations related to `ismutable` -->
- [ ] #51479 <!-- prevent code loading from lookin in the versioned
environment when building Julia -->

KristofferC removed the backport 1.10 label

kpamnany mentioned this pull request

jl_print_task_backtraces does not show some task backtraces #53057

Open

mofeing mentioned this pull request

Backport ebae716 to v1.10 #56354

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature multithreading