Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump the Tar stdlib from 5606269 to 5914ef9 #46731

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 13, 2022

I updated the Tar.jl stdlib. There have been some invalidation fixes recently, so I would like to get this backported to Julia 1.8.

@DilumAluthge DilumAluthge added the stdlib Julia's standard library label Sep 13, 2022
@ranocha ranocha added compiler:latency Compiler latency backport 1.8 Change should be backported to release-1.8 labels Sep 13, 2022
@DilumAluthge
Copy link
Member

For external stdlibs (i.e. stdlibs that live in external repos), the backport process is a little bit different. We don't apply the backport label to the bump PR in this repo. Instead, the external stdlib needs to go through its own backports process. The full details are here: JuliaSparse/SparseArrays.jl#249

@DilumAluthge DilumAluthge removed the backport 1.8 Change should be backported to release-1.8 label Sep 13, 2022
@ranocha
Copy link
Member Author

ranocha commented Sep 13, 2022

Okay, thanks for the info. I didn't know that. Do you have the rights to create these branches there? I don't, so I can't help with that.
Note that we currently just use the master of Tar.jl in Julia. This PR bumps the version to the latest version on master.

@DilumAluthge
Copy link
Member

DilumAluthge commented Sep 13, 2022

According to https://github.com/JuliaLang/julia/blob/release-1.8/stdlib/Tar.version, the release-1.8 branch of the JuliaLang/julia repo is currently using the 0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595 commit of the JuliaIO/Tar.jl repo:

TAR_BRANCH = master
TAR_SHA1 = 0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595
TAR_GIT_URL := https://github.com/JuliaIO/Tar.jl.git
TAR_TAR_URL = https://api.github.com/repos/JuliaIO/Tar.jl/tarball/$1

In the JuliaIO/Tar.jl repo, at the 0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595 commit, the Project.toml file has the version number 1.10.0: https://github.com/JuliaIO/Tar.jl/blob/0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595/Project.toml#L1-L4

Therefore, I have created the release-1.10 branch in the JuliaIO/Tar.jl repo, where the branch points to the 0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595 commit. To do this, I ran the following steps:

cd $(mktemp -d)
git clone [email protected]:JuliaIO/Tar.jl.git
cd Tar.jl
git branch release-1.10 0f8a73d5cd4b0c8f1f3c36799c96e9515e9dc595
git push origin release-1.10
cd ..
rm -rf Tar.jl

Now, you should be able to make a backports PR in the JuliaIO/Tar.jl repo where the target branch (base branch) of the PR is the release-1.10 branch in that repo.

@DilumAluthge
Copy link
Member

Note that we currently just use the master of Tar.jl in Julia.

Ah, good catch. I've made a PR to fix that: #46733

@ranocha
Copy link
Member Author

ranocha commented Sep 14, 2022

@DilumAluthge I made a PR to Tar.jl following your instructions. How shall we proceed with this PR?

@DilumAluthge DilumAluthge merged commit f5842f8 into JuliaLang:master Sep 15, 2022
@ranocha ranocha deleted the hr/bump_Tar branch September 15, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants