Profile: Use grace period to avoid trailing signals from timer #44268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
changed the title
sleep_ms
IanButterworth
force-pushed
the
ib/time_ms_fix
branch
from
e937578 to
afb5878
Compare
|
@DilumAluthge I believe this fixes the profile failures |
KristofferC
pushed a commit
that referenced
this pull request
Feb 23, 2022
(cherry picked from commit e723d37)
33 tasks
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short sleep approach in #44199 appears unreliable. This uses a longer non-sleeping grace period approach