-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile: Minor fixes. Signal handling fix. #44199
Profile: Minor fixes. Signal handling fix. #44199
Conversation
2d09b95
to
994e8b0
Compare
994e8b0
to
93dce80
Compare
@vtjnash I've seen some rare instances of this kind of behavior on linux with regular profiling
Also there are some spurious info request prints in the linux CI, where the only ones Given I suspect the issue may be that the timer might still spit out a signal after
So I added the 93dce80 to add some buffer to let a stray signal pass before declaring There may be a better way to do this, or my understanding may be flawed. |
There may be a better fix than what is described in #44199 (comment) But I think it would be good to get these in given there are unexplained intermittent failures on |
Hasn't appeared to fix the spurious triggers on linux Perhaps the sleep is too short? |
(cherry picked from commit 072c041)
Addressing some post-merge review suggestions from #44185 (review)