Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MSVC and ICC stuff in the build system. #42586

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Remove MSVC and ICC stuff in the build system. #42586

merged 3 commits into from
Oct 14, 2021

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah added the building Build system, or building Julia or its dependencies label Oct 10, 2021
@ViralBShah ViralBShah requested a review from vtjnash October 10, 2021 21:13
@vchuravy
Copy link
Member

@barche seems to embed Julia with MSVC? #42255 (comment)
Bart do you need to build Julia with MSVC as well?

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 10, 2021 •
edited
Loading

Huh - I always thought that was old unused code. If it works and is actually being used, then we should just close this.

@ViralBShah
Copy link
Member Author

Does anyone know if the ICC/IFORT stuff works?

@vchuravy
Copy link
Member

Does anyone know if the ICC/IFORT stuff works?

No clue, also I wonder if it matters since https://software.intel.com/content/www/us/en/develop/blogs/adoption-of-llvm-complete-icx.html

@ViralBShah
Copy link
Member Author

icc/ifortran are quite problematic: #35241 (comment)

@barche
Copy link
Contributor

barche commented Oct 10, 2021

@barche seems to embed Julia with MSVC? #42255 (comment)
Bart do you need to build Julia with MSVC as well?

No, there is no need to build Julia with MSVC to use MSVC for embedding. I don't really do this embedding myself, but it comes up from time to time when people try to build libcxxwrap-julia with MSVC. Since this PR only changes build system files from Julia, it will have no impact for CxxWrap.

@giordano
Copy link
Contributor

No, there is no need to build Julia with MSVC to use MSVC for embedding.

I thought that embedding in MSVC would require having built Julia with the same standard C++ library.

@barche
Copy link
Contributor

barche commented Oct 11, 2021

I thought that embedding in MSVC would require having built Julia with the same standard C++ library.

Because the interface is C, this is not required (and I have never attempted it). There are corner cases, however, the most obvious one being that you can't allocate in the MSVC code and free in Julia and vice-versa. So this is not as robust as the BinaryBuilder solution, but useful for local development or for interfacing with libraries that only build with MSVC.

@ViralBShah
Copy link
Member Author

ViralBShah commented Oct 11, 2021 •
edited
Loading

@staticfloat @DilumAluthge I'm not sure I understand what the issue is on package_win64 and package_win32. The build seems successful.

vchuravy
vchuravy reviewed Oct 11, 2021
View reviewed changes
Make.inc Show resolved Hide resolved
@DilumAluthge
Copy link
Member

@staticfloat Looks like we're running out of disk space in the Windows VMs?

vtjnash
vtjnash approved these changes Oct 12, 2021
View reviewed changes
src/support/Makefile Show resolved Hide resolved
src/Makefile Show resolved Hide resolved
@vtjnash vtjnash merged commit b1b0a3c into master Oct 14, 2021
@vtjnash vtjnash deleted the vs/delete-msvc branch October 14, 2021 20:04
@fingolfin
Copy link
Member

So I am confused: does this mean support for building with MSVC and ICC is removed in general? If so, shouldn't the various uses of _MSC_VER and __INTEL_COMPILER in the C kernel code also be removed?

@fingolfin
Copy link
Member

Oh, I just found #35241 (comment) so I guess that means it should indeed be removed

fingolfin added a commit to fingolfin/julia that referenced this pull request Oct 19, 2021
@fingolfin
Remove MSVC / ICC specific code
6574cea 
Support for building MSVC and ICC was removed from the build system in
PR JuliaLang#42586; this patch removes more leftover code which was there to
support MSVC / ICC.
fingolfin added a commit to fingolfin/julia that referenced this pull request Oct 19, 2021
@fingolfin
Remove MSVC / ICC specific code
22faa21 
Support for building MSVC and ICC was removed from the build system in
PR JuliaLang#42586; this patch removes more leftover code which was there to
support MSVC / ICC.
This was referenced Oct 19, 2021
Merged
Open
vtjnash pushed a commit that referenced this pull request Oct 19, 2021
@fingolfin
Remove MSVC / ICC specific code (#42703)
dc74954 
Support for building MSVC and ICC was removed from the build system in
PR #42586; this patch removes more leftover code which was there to
support MSVC / ICC.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@ViralBShah @LilithHafner
Remove MSVC and ICC stuff in the build system (JuliaLang#42586)
a417dd7
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@fingolfin @LilithHafner
Remove MSVC / ICC specific code (JuliaLang#42703)
f62a6f1 
Support for building MSVC and ICC was removed from the build system in
PR JuliaLang#42586; this patch removes more leftover code which was there to
support MSVC / ICC.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@ViralBShah @LilithHafner
Remove MSVC and ICC stuff in the build system (JuliaLang#42586)
511db43
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@fingolfin @LilithHafner
Remove MSVC / ICC specific code (JuliaLang#42703)
a1660de 
Support for building MSVC and ICC was removed from the build system in
PR JuliaLang#42586; this patch removes more leftover code which was there to
support MSVC / ICC.
vtjnash added a commit that referenced this pull request Mar 28, 2022
@vtjnash
remove dead code since #42586 [NFC]
dc178dd
@vtjnash vtjnash mentioned this pull request Mar 28, 2022
Merged
vtjnash added a commit that referenced this pull request Mar 29, 2022
@vtjnash
remove dead code since #42586 [NFC] (#44782)
c2cec7a
inkydragon pushed a commit to inkydragon/julia that referenced this pull request Jun 18, 2022
deps/dSFMT: remove old MSVC deps
b5c6b24 
xref: JuliaLang#42586
ViralBShah pushed a commit that referenced this pull request Jun 18, 2022
deps/dSFMT: remove old MSVC deps (#45735)
0ffa235 
xref: #42586
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@pcjentsch
deps/dSFMT: remove old MSVC deps (JuliaLang#45735)
e8b5d38 
xref: JuliaLang#42586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ViralBShah @vchuravy @barche @giordano @DilumAluthge @fingolfin @vtjnash