-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make files: remove ICC/IFC/MSVC cruft #35241
Comments
As it appears something is wrong with the download link/site. Following methods lead to the same error:
Is there an alternative way to compile Julia? ie: manually downloading dependencies... |
|
@einzigsue I suspect that some architecture detection is failing and that is leading to a malformed URL. What system are you building on? Can you use the official binaries and share |
I can build 1.3.1 successfully on the same machine and this is what versioninfo() says in my 1.3.1 build. |
v1.4.1 shares the error. |
Something in deps/tools/bb-install.mk is not returning expected values - perhaps because the outputs are not matching what the tools expect. Could you try run those checks on your system and see what they give? |
Perhaps will be addressed by #35653 |
Can you try the latest master? |
This is still an issue for me while trying to build Julia 1.4.2 on Arch Linux. |
I should probably open a new issue, but I wanted to update my last, rather lacking, comment for posterity: I have learned that I am experiencing the same error as above and in #35885 because I am trying to compile If I understand correctly, then when bb-install.mk is called by libuv.mk or dsfmt.mk If I install If I do not install |
Should be fixed. |
I ran into the same issue as shanewstone, using |
I'm pretty sure we don't support building julia with |
in Make.inc |
Yes, that does exist. @vtjnash @staticfloat Any thoughts if we should just remove those sections? Nobody ever builds or tests with icc/ifc regularly - so it is always a cause for concern what bugs may lurk. |
The build instructions do only mention gcc/clang: https://github.com/JuliaLang/julia/blob/master/doc/build/build.md |
I don't know anyone who has ever tried to build Julia with |
There's no real benefit to supporting ICC or IFC since, aside from Julia's runtime, which isn't particularly performance sensitive, code is always generated by LLVM, regardless of which C compiler Julia was compiled with. Early on we made some efforts to support other compilers, including ICC and MSVC, but that never worked very well, has completely bitrotted, and there's no compelling reason or will to get those things working. Even if someone did get them working, we'd then have to test all those combinations in CI to keep them working. Just a whole lot of upfront and ongoing work for zero benefit. The only reasonable course of action here is to delete the stuff in make files that even suggests that ICC, IFC or any other compilers besides gcc and clang are supported. |
Accordingly, I've changed this to be a build system maintenance issue: someone just needs to go through the make files and delete references to ICC, IFC and any other unsupported compilers. |
Should MSVC also go? |
Yes 👍🏻. |
@musm @vtjnash @staticfloat @vchuravy - Double checking with a few more folks here that we no longer use the MSVC stuff in the Makefiles for our Windows builds. I can put together a PR getting rid of all this stuff. |
MSVC is not used or tested anywhere. |
Ok - I was just wondering if our windows build sets it or something (even though it doesn't use MSVC). |
Hi There,
I am compiling julia 1.4.0 from source and found the error message
where $JULIAHOME is the folder I did git checkout v1.4.0.
The url passed to jldownload is wrong, with an extra dot before .tar.gz.
Can someone quickly fix this?
Many thanks in advance
Yue
The text was updated successfully, but these errors were encountered: