Remove fast_unwind_on_malloc and malloc_context_size restrictions in ASAN CI #42515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Oct 6, 2021
|
Ah great!
…On Tue, Oct 5, 2021 at 8:30 PM Takafumi Arakaki ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In contrib/asan/Make.user.asan
<#42515 (comment)>:
> @@ -18,6 +18,3 @@ override WITH_GC_DEBUG_ENV=1
# default to a debug build for better line number reporting
override JULIA_BUILD_MODE=debug
-
-# make ASAN consume less memory
-export ASAN_OPTIONS=detect_leaks=0:fast_unwind_on_malloc=0:allow_user_segv_handler=1:malloc_context_size=2
@maleadt <https://github.com/maleadt> added this in #41675
<#41675>
https://github.com/JuliaLang/julia/blob/5d87cb92a2abb5bc62dcd777af01a831de1f51cf/cli/loader_exe.c#L18-L20
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#42515 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDO2SDEHTSUQPPPNXKSVTUFOKA5ANCNFSM5FNATNZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
maleadt
approved these changes
Oct 6, 2021
|
There was a simple check to see if ASAN can detect a bug but we removed it #42229 since my implementation @DilumAluthge Do you want to wait for merging this until the issue in #41936 is resolved? |
Yeah I think that makes sense. |
These options are already set in loader_exe.c.
maleadt
force-pushed
the
asan-unlimited
branch
from
1e4182d to
edfa95d
Compare
|
Rebased. |
|
We need to fix the ASAN tests first (#42540) |
|
Oh oops, I thought that had been fixed already. Sorry for the noise then. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…ASAN CI (JuliaLang#42515) No need to set ASAN_OPTIONS any more either: these options are already set in `loader_exe.c` with `__asan_default_options`.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ASAN CI (JuliaLang#42515) No need to set ASAN_OPTIONS any more either: these options are already set in `loader_exe.c` with `__asan_default_options`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements @maleadt's suggestion #42498 (comment)
A quick benchmark (#42498 (comment)) suggests the peak memory consumption is about 5GB. I think the CI machines can handle this.