Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) #42229

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

DilumAluthge
Copy link
Member

Of the 20 most recent julia-master-experimental jobs on the master branch, 7 have passed and 13 have failed.

I don't think it's particularly useful to keep running a job that is this flaky. I would propose that we disable the asan job for now. Once we figure out how to get it to reliably pass, we can consider re-enabling it.

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 13, 2021
@DilumAluthge DilumAluthge requested a review from a team as a code owner September 13, 2021 07:19
@DilumAluthge DilumAluthge removed the request for review from a team September 13, 2021 07:19
@tkf
Copy link
Member

tkf commented Sep 13, 2021

Looking at the last 10 failures in the master branch https://buildkite.com/julialang/julia-master-experimental/builds?branch=master it looks like all of them failed on the Test that ASAN is enabled step. So, it looks like only my script for checking ASAN is failing. Maybe we can keep the build step? Since the compilation of the system images already runs under ASAN, I think the build step alone already is testing a substantial portion of the ASAN-enabled runtime.

Co-authored-by: Takafumi Arakaki <[email protected]>
@DilumAluthge DilumAluthge changed the title CI (Buildkite): disable the experimental asan job CI (Buildkite): in the experimental asan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step) Sep 13, 2021
@DilumAluthge DilumAluthge requested a review from tkf September 13, 2021 08:00
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Sep 13, 2021

Let's give that a try.

@DilumAluthge DilumAluthge changed the title CI (Buildkite): in the experimental asan job, remove the contrib/asan/check.jl step (but keep the "Build julia-debug with ASAN" step) CI (Buildkite): in the experimental asan job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) Sep 13, 2021
Copy link
Member

@tkf tkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

@DilumAluthge DilumAluthge merged commit 60fd334 into master Sep 13, 2021
@DilumAluthge DilumAluthge deleted the dpa/remove-asan-buildkite branch September 13, 2021 21:16
KristofferC pushed a commit that referenced this pull request Sep 15, 2021
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
(cherry picked from commit 60fd334)
KristofferC pushed a commit that referenced this pull request Sep 15, 2021
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
(cherry picked from commit 60fd334)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
(cherry picked from commit 60fd334)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229)

Co-authored-by: Takafumi Arakaki <[email protected]>

Co-authored-by: Takafumi Arakaki <[email protected]>
(cherry picked from commit 60fd334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants