-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI (Buildkite): in the experimental asan
job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)
#42229
Conversation
Looking at the last 10 failures in the master branch https://buildkite.com/julialang/julia-master-experimental/builds?branch=master it looks like all of them failed on the |
Co-authored-by: Takafumi Arakaki <[email protected]>
asan
jobasan
job, remove the contrib/asan/check.jl
step (but keep the "Build julia-debug with ASAN" step)
Let's give that a try. |
asan
job, remove the contrib/asan/check.jl
step (but keep the "Build julia-debug with ASAN" step)asan
job, remove the "Test that ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this LGTM!
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]> (cherry picked from commit 60fd334)
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]> (cherry picked from commit 60fd334)
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]> (cherry picked from commit 60fd334)
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]>
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (JuliaLang#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]>
… ASAN is enabled" step (but keep the "Build julia-debug with ASAN" step) (#42229) Co-authored-by: Takafumi Arakaki <[email protected]> Co-authored-by: Takafumi Arakaki <[email protected]> (cherry picked from commit 60fd334)
Of the 20 most recent
julia-master-experimental
jobs on themaster
branch, 7 have passed and 13 have failed.I don't think it's particularly useful to keep running a job that is this flaky. I would propose that we disable the
asan
job for now. Once we figure out how to get it to reliably pass, we can consider re-enabling it.