Remove overly restrictive Strided* constraints in LinearAlgebra
#35420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Apr 10, 2020
| @@ -641,7 +641,7 @@ function rcswap!(i::Integer, j::Integer, X::StridedMatrix{<:Number}) | |||
| end | |||
|
|
|||
| """ | |||
| log(A{T}::StridedMatrix{T}) | |||
| log(A{T}::AbstractMatrix{T}) | |||
There was a problem hiding this comment.
Just came across this: the A{T} looks wrong here. Should be simply A?
|
So awesome! Previously partially attempted in #32147 (and I think elsewhere, too). Also looks like it fixes JuliaLang/LinearAlgebra.jl#620. Should also fix JuliaLang/LinearAlgebra.jl#345, JuliaLang/LinearAlgebra.jl#377, #32120, and JuliaLang/LinearAlgebra.jl#587. But the challenge is in all those ambiguities. This is a bit of a rats nest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JuliaLang/LinearAlgebra.jl#713