-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove StridedArray restrictions on factorization objects. #620
Comments
And we also need to add restrictions to |
You may find JuliaLang/julia#31149 helpful as you go through these — I use it semi-regularly when dealing with method lists that are ridiculous. I've not merged it since nobody has reviewed or voiced their support for it. |
I completely agree for some of the "outer" functions which only converts to the right element type but I have more mixed feelings for the actual implementations. While the generic implementations don't use the stridedness of |
We could overload for |
Something like might end up as the solution. GPUArrays and now also DistributedArrays have a flag to disallow scalar |
I'm going through the QR, Cholesky, etc. factorization codes as I re-write the factorizations in BandedMatrices.jl (and elsewhere) to be consistent with Base, and there are a large amount of unnecessary restrictions to
StridedArray
s. This is particularly silly as many of the factorizations have generic Julia fallbacks which do not use strided-ness at all.I can do a PR when I get some time.
The text was updated successfully, but these errors were encountered: