Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for Julia 1.4.1 #35229

Merged
merged 34 commits into from
Apr 14, 2020
Merged

Backports for Julia 1.4.1 #35229

merged 34 commits into from
Apr 14, 2020

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Mar 23, 2020 •
edited
Loading

Backported PRs:

Need manual backport:

Non-merged PRs with backport label:

Keno and others added 6 commits March 23, 2020 09:15
@Keno @KristofferC
Fix regression in inlining of invoke (#34906)
de3914e 
When we added the check to prevent inlining through ambiguous methods,
we failed exclude this check for calls to `invoke` (which skip ambiguous
methods, since the method is explicitly selected). Fixes #34900.

(cherry picked from commit 6abc852)
@carstenbauer @KristofferC
Fix inverse of SVD of complex matrix (#34872)
ec8f59c 
Closes #34866

(cherry picked from commit f709331)
@Keno @KristofferC
Sockets: fix return value of getpeername/getsockname (#34986)
1d13caa 
(cherry picked from commit 598209d)
@ViralBShah @KristofferC
Rebase of #28526 on master (#34989)
4e11ce9 
* fix \ SparseVector

* split (\) for sparsevector;
test for Factor and Symmetric Sparse Matrix

Co-authored-by: Chi Po Choi <[email protected]>
(cherry picked from commit d2f9677)
@staticfloat @KristofferC
walkdir: avoid symlink loops when follow_symlinks == false (#35006)
5cf6725 
* walkdir: avoid symlink loops when `follow_symlinks == false`

Because `isdir()` attempts to dereference symlinks, attempting to
`walkdir()` trees that contain symlink loops errors out. This change
modifies `walkdir()` to treat all symlinks as files when
`follow_symlinks == false`.

* rm: When checking `filemode()`, use `lstat()` to avoid following symlinks

(cherry picked from commit 178ac97)
@omus @KristofferC
Support git config credential resetting (#35064)
f1593e1 
(cherry picked from commit 0f1b119)
@KristofferC KristofferC added needs nanosoldier run This PR should have benchmarks run on it DO NOT MERGE Do not merge this PR! needs pkgeval Tests for all registered packages should be run with this change release Release management and versioning. labels Mar 23, 2020
@maleadt
Copy link
Member

maleadt commented Mar 23, 2020

Could #34760 be considered? It is technically a new feature, but it's unexported, completely unused by Base, but greatly simplifies quite some code in CUDAnative. Should be a clean backport too.

fredrikekre
fredrikekre reviewed Mar 23, 2020
View reviewed changes
base/gcutils.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC force-pushed the backports-release-1.4.1 branch from bc2fa4b to 8f1218a Compare March 23, 2020 08:58
vchuravy and others added 10 commits March 29, 2020 17:44
@vchuravy
[LLVM8] add patches for D75072 and D65174
c6673ae 
(cherry picked from commit d20184f)
@nalimilan @vchuravy
change libLLVM suffix to match build-configuration
9131e12 
Backport of 5e0cab6.
@vchuravy
yank LLVM assert checksums
b4be5f2
@vchuravy
bump LLVM BB release
7538e15
@rfourquet @KristofferC
fix #35225, issubset on empty ranges (#35244)
1156956 
(cherry picked from commit 64ee8ab)
@KristofferC
Linux: Remove --nodetach option for xsel copy. (#35180)
bc6fa8f 
The `--nodetach` option causes `clipboard(x)` to hang indefinitely on (most? All which I have tried) linux systems. Removing this option fixes `clipboard(x)`, but briefly spawns a child process. Since `clipboard(x)` is designed for interactive use, this shouldn't be an issue.

(cherry picked from commit 5dd6676)
@JeffBezanson @KristofferC
fix #35295, typo in change to clipboard on linux (#35310)
f73a14c 
(cherry picked from commit 33df293)
@staticfloat @KristofferC
Update UnicodeData checksum (#35356)
625be9e 
Upstream has apparently modified this file as of March 30th 2020, which
is annoying as it has broken all older builds of Julia attempting to
download and check this file.

(cherry picked from commit c980519)
@JeffBezanson @KristofferC
fix a bug preventing inlining of getindex of const globals (#35239)
bc6adcd 
(cherry picked from commit 1f78749)
@timholy @KristofferC
Fix offset when widening collections
069f137 
(cherry picked from commit 1da2480)
@nanosoldier

This comment has been minimized.

Sign in to view
@maleadt

This comment has been minimized.

Sign in to view
@nanosoldier

This comment has been minimized.

Sign in to view
@maleadt

This comment has been minimized.

Sign in to view
@KristofferC KristofferC removed the needs nanosoldier run This PR should have benchmarks run on it label Apr 8, 2020
@nanosoldier

This comment has been minimized.

Sign in to view
@KristofferC

This comment has been minimized.

Sign in to view
@vchuravy vchuravy mentioned this pull request Apr 9, 2020
Merged
@KristofferC
Merge pull request #35405 from JuliaLang/vc/bump_bb_1.4
7f5adff 
[1.4.1] Update LLVM and OpenBLAS BB release
@nanosoldier

This comment has been minimized.

Sign in to view
@KristofferC
Copy link
Member Author

We bumped LLVM and OpenBLAS so better rerun all the checks...

@nanosoldier runbenchmarks(ALL, vs = ":release-1.4")

@KristofferC
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.4")

@rfourquet
Copy link
Member

When is planned the release of 1.4.1? I will try before then to make a 1.4 version of #35274 which fixes a bug.

@KristofferC
Copy link
Member Author

When is planned the release of 1.4.1?

As soon as this branch looks ready.,

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@KristofferC
Copy link
Member Author

@nanosoldier runtests(["ApproxBayes", "Autologistic", "BlobTracking", "CombineML", "DiffEqGPU", "HELICS", "MAT", "MusicXML", "OhMyREPL"], vs = ":release-1.4")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here. cc @maleadt

@KristofferC KristofferC removed DO NOT MERGE Do not merge this PR! needs pkgeval Tests for all registered packages should be run with this change labels Apr 12, 2020
@KristofferC KristofferC changed the title WIP: Backports for Julia 1.4.1 Backports for Julia 1.4.1 Apr 14, 2020
@KristofferC KristofferC merged commit ec31c9a into release-1.4 Apr 14, 2020
@KristofferC KristofferC deleted the backports-release-1.4.1 branch April 14, 2020 08:03
@maleadt maleadt mentioned this pull request Apr 14, 2020
Merged
@maleadt
Copy link
Member

maleadt commented Apr 14, 2020

The LLVM asserts build is broken on this branch (works with v1.4.0):

curl: (22) The requested URL returned error: 404 Not Found
make[1]: *** [/home/tim/Julia/julia/deps/llvm.mk:579: /home/tim/Julia/julia/deps/srccache/LLVM_full_assert.v8.0.1-3.x86_64-linux-gnu-cxx11.tar.gz] Error 22

https://github.com/JuliaBinaryWrappers/LLVM_full_assert_jll.jl/releases/download/LLVM_full_assert-v8.0.1+3/LLVM_full_assert.v8.0.1.x86_64-linux-gnu-cxx11.tar.gz doesn't exist whereas https://github.com/JuliaBinaryWrappers/LLVM_full_assert_jll.jl/releases/download/LLVM_full_assert-v8.0.1+0/LLVM_full_assert.v8.0.1.x86_64-linux-gnu-cxx11.tar.gz does. cc @vchuravy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.