Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase of #28526 on master: Sparse cholesky solve with sparse RHS #34989

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Rebase of #28526 on master: Sparse cholesky solve with sparse RHS #34989

merged 2 commits into from
Mar 5, 2020

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Mar 4, 2020 •
edited
Loading

Rebase #28526 on top of master.

cc @pochoi

pochoi added 2 commits March 3, 2020 22:29
@pochoi @ViralBShah
fix \ SparseVector
3e597df
@pochoi @ViralBShah
split (\) for sparsevector;
0a92f6f 
test for Factor and Symmetric Sparse Matrix
@ViralBShah ViralBShah changed the title Rebase of #28526 Rebase of #28526 on master Mar 4, 2020
@ViralBShah ViralBShah mentioned this pull request Mar 4, 2020
Closed
@ViralBShah ViralBShah added sparse Sparse arrays linear algebra Linear algebra labels Mar 4, 2020
@ViralBShah ViralBShah requested a review from dkarrasch March 4, 2020 03:54
dkarrasch
dkarrasch reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I should add that I'm not familiar with the specific spsolve calls. Shall we have another non-trivial test with a small, densely populated sparse SPD matrix, and compare against the classic dense solution?

@ViralBShah
Copy link
Member Author

I think we should not need more tests because this only handles the case of the sparse rhs by making it dense and thus reducing the missing case to an existing case.

@ViralBShah
Copy link
Member Author

CI failures are unrelated. Merging.

@ViralBShah ViralBShah merged commit d2f9677 into master Mar 5, 2020
@ViralBShah ViralBShah deleted the pochoi-sp_chol branch March 5, 2020 02:19
@ViralBShah ViralBShah changed the title Rebase of #28526 on master Rebase of #28526 on master: Sparse linear systems with sparse RHS Mar 5, 2020
@ViralBShah ViralBShah changed the title Rebase of #28526 on master: Sparse linear systems with sparse RHS Rebase of #28526 on master: Sparse cholesky solve with sparse RHS Mar 5, 2020
@ViralBShah ViralBShah added backport 1.4 triage This should be discussed on a triage call labels Mar 5, 2020
@pochoi
Copy link
Contributor

pochoi commented Mar 5, 2020

Thank you so much!

@KristofferC KristofferC removed the triage This should be discussed on a triage call label Mar 23, 2020
KristofferC pushed a commit that referenced this pull request Mar 23, 2020
@ViralBShah @KristofferC
Rebase of #28526 on master (#34989)
4e11ce9 
* fix \ SparseVector

* split (\) for sparsevector;
test for Factor and Symmetric Sparse Matrix

Co-authored-by: Chi Po Choi <[email protected]>
(cherry picked from commit d2f9677)
@KristofferC KristofferC mentioned this pull request Mar 23, 2020
Merged
27 tasks
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
@ViralBShah @pochoi @ravibitsgoa
Rebase of JuliaLang#28526 on master (JuliaLang#34989)
645aa53 
* fix \ SparseVector

* split (\) for sparsevector;
test for Factor and Symmetric Sparse Matrix

Co-authored-by: Chi Po Choi <[email protected]>
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@ViralBShah @pochoi @KristofferC
Rebase of #28526 on master (#34989)
76c0355 
* fix \ SparseVector

* split (\) for sparsevector;
test for Factor and Symmetric Sparse Matrix

Co-authored-by: Chi Po Choi <[email protected]>
Moelf added a commit to Moelf/julia that referenced this pull request Jun 10, 2020
@Moelf
Revert "Rebase of JuliaLang#28526 on master (JuliaLang#34989)"
f6b1c8a 
This reverts commit d2f9677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch left review comments

Assignees
No one assigned
Labels
linear algebra Linear algebra sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViralBShah @pochoi @dkarrasch @KristofferC