Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle LinearAlgebra tests to the front of the test queue #34456

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

Keno
Copy link
Member

@Keno Keno commented Jan 21, 2020

They take much longer than the rest of the tests, so if they're
run at the end, they often determine the length of the entire test
run. Instead, try running them at the start while there's still
plenty of work to be done. Hopefully this will reduce overall duration
of CI tests. If this doesn't work out as planned, we can try a more
fine grained strategy to load balancing (e.g. by checking in a table
of approximate runtimes and sorting according to that).

@tkf
Copy link
Member

tkf commented Jan 21, 2020

Sorry that this test dominates the CI time (I wrote this)... It is a super brute force test but it's really useful for catching bugs.

FYI, you can reduce this number to make it shorter, but at the cost of the bug to be discovered much later than the actual PR touching the relevant code

n_samples = 1.5
# n_samples = Inf # to try all combinations

@Keno
Copy link
Member Author

Keno commented Jan 21, 2020

It's not just addmul, some of the others also take a bunch of time.

@tkf
Copy link
Member

tkf commented Jan 21, 2020

Ah, OK. I mixed it with JuliaLang/LinearAlgebra.jl#690.

@Keno
Copy link
Member Author

Keno commented Jan 21, 2020

I mean, they're related, but if this works (maybe while simultaneously bumping the number of cores allotted to testing to make sure that all the LinearAlgebra tests start at one, then the other one is less urgent.

@JeffBezanson
Copy link
Member

Looks like there are ambiguities in Furlongs.jl that are test-order-dependent (only errors if Furlongs is loaded before the ambiguity tests). I'll try to fix them.

@Keno
Copy link
Member Author

Keno commented Jan 23, 2020

This made the aarch64 bot 10 minutes faster. I think it's worth doing once the ambiguity error is fixed.

@JeffBezanson
Copy link
Member

This can be rebased and merged now.

@JeffBezanson JeffBezanson added the ci Continuous integration label Jan 29, 2020
They take much longer than the rest of the tests, so if they're
run at the end, they often determine the length of the entire test
run. Instead, try running them at the start while there's still
plenty of work to be done. Hopefully this will reduce overall duration
of CI tests. If this doesn't work out as planned, we can try a more
fine grained strategy to load balancing (e.g. by checking in a table
of approximate runtimes and sorting according to that).
@Keno Keno force-pushed the kf/linalgcifirst branch from b6a944a to b8798a2 Compare March 4, 2020 20:15
@dkarrasch
Copy link
Member

Could this be rebased to see whether it resolves the time-outs we see frequently?

@mbauman
Copy link
Member

mbauman commented Mar 6, 2020

We used to do this, but I guess we lost it in the stdlib shakeup.

@Keno Keno merged commit 4ee9be2 into master Mar 6, 2020
@Keno Keno deleted the kf/linalgcifirst branch March 6, 2020 18:27
ravibitsgoa pushed a commit to ravibitsgoa/julia that referenced this pull request Apr 9, 2020
…#34456)

They take much longer than the rest of the tests, so if they're
run at the end, they often determine the length of the entire test
run. Instead, try running them at the start while there's still
plenty of work to be done. Hopefully this will reduce overall duration
of CI tests. If this doesn't work out as planned, we can try a more
fine grained strategy to load balancing (e.g. by checking in a table
of approximate runtimes and sorting according to that).
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
They take much longer than the rest of the tests, so if they're
run at the end, they often determine the length of the entire test
run. Instead, try running them at the start while there's still
plenty of work to be done. Hopefully this will reduce overall duration
of CI tests. If this doesn't work out as planned, we can try a more
fine grained strategy to load balancing (e.g. by checking in a table
of approximate runtimes and sorting according to that).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants