Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing generators.jl test #34450

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Missing generators.jl test #34450

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a5bd1
Missing generators.jl test
bramtayl Jan 20, 2020
047a48b
fix
bramtayl Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/iterators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
using Base.Iterators
using Random

import Base: IteratorSize, SizeUnknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import Base: IteratorSize, SizeUnknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@test IteratorSize(Any) isa SizeUnknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test IteratorSize(Any) isa SizeUnknown
@test Base.IteratorSize(Any) isa Base.SizeUnknown

seems like it would make the test more "local".


# zip and filter iterators
# issue #4718
@test collect(Iterators.filter(x->x[1], zip([true, false, true, false],"abcd"))) == [(true,'a'),(true,'c')]
Expand Down