Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing generators.jl test #34450

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Missing generators.jl test #34450

merged 2 commits into from
Jan 27, 2020

Conversation

bramtayl
Copy link
Contributor

@Keno
Copy link
Member

Keno commented Jan 20, 2020

Looks like this has a whitespace issue.

@bramtayl
Copy link
Contributor Author

Maybe the whitespace check fail is unrelated? In any case, I can't find any trailing whitespace

@maleadt
Copy link
Member

maleadt commented Jan 21, 2020

Whitespace check fail was a git fetch error, I restarted the test.

@bramtayl
Copy link
Contributor Author

Bump?

KristofferC
KristofferC reviewed Jan 23, 2020
View reviewed changes
test/iterators.jl Outdated
@@ -3,6 +3,9 @@
using Base.Iterators
using Random

import Base: IteratorSize, SizeUnknown
@test IteratorSize(Any) isa SizeUnknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@test IteratorSize(Any) isa SizeUnknown
@test Base.IteratorSize(Any) isa Base.SizeUnknown

seems like it would make the test more "local".

KristofferC
KristofferC reviewed Jan 23, 2020
View reviewed changes
test/iterators.jl Outdated
@@ -3,6 +3,9 @@
using Base.Iterators
using Random

import Base: IteratorSize, SizeUnknown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import Base: IteratorSize, SizeUnknown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@bramtayl
Copy link
Contributor Author

Bump?

@StefanKarpinski StefanKarpinski merged commit ed177d1 into JuliaLang:master Jan 27, 2020
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@bramtayl @KristofferC
Missing generators.jl test (#34450)
a4810b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bramtayl @Keno @maleadt @KristofferC @StefanKarpinski