REPL shell mode for Windows #33474

musm · 2019-10-04T23:02:11Z

Previous Attempts: #31490 #23703 #21294 #20776 #11478 #33427 #11478

Some of these approaches tried to implement special Windows rule in the shell_escape mechanism, I think some also tried to pass 'raw' strings to the shell, all with varying degrees of success.

Fixes #6316 #23597

References

Powershell:

CMD:

musm · 2019-10-05T03:36:47Z

base/Base.jl

 include("regex.jl")
+include("shell.jl")


This change is needed since we use substitution string in the shell.jl file.

musm · 2019-10-05T03:59:36Z

base/client.jl

@@ -31,8 +31,15 @@ stackframe_lineinfo_color() = repl_color("JULIA_STACKFRAME_LINEINFO_COLOR", :bol
 stackframe_function_color() = repl_color("JULIA_STACKFRAME_FUNCTION_COLOR", :bold)

 function repl_cmd(cmd, out)
-    shell = shell_split(get(ENV, "JULIA_SHELL", get(ENV, "SHELL", "/bin/sh")))
+    shell = get(ENV, "JULIA_SHELL", nothing)


Should we cache this value in a reference? So that we don't have to look it up each time the Julia REPL is entered?

musm · 2019-10-05T04:02:08Z

base/client.jl

+                command = Cmd(`$shell /c $(shell_escape_CMDly(shell_escape_winsomely(cmd)))`, windows_verbatim=true)
+            elseif shell_name in ("powershell", "pwsh")
+                command = Cmd(`$shell -Command $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))`, windows_verbatim=true)
+            elseif shell_name == "busybox"


Is this really necessary ? We don't even ship with busy box anymore...

I think this is from older julia code, so my suggestion is to just remove it.

arg .. looks like it is needed for testing on windows... maybe we should look into WSL for testing on windows instead of downloading busybox?

Still something about this rubs me the wrong way. We should still try to remove this and try to work around them in the tests. Thoughts welcome

I think we should make this the else block

What exactly do you mean by "making this the else block"?
Do you mean :

if shell_name == "cmd" command = _CMD_execute(shell, cmd) elseif shell_name in ("powershell", "pwsh") command = _powershell_execute(shell, cmd) else command = `$shell sh -c $(shell_escape_posixly(cmd))`

Is the assumption here that if you don't want cmd or powershell then you probably want it to default to use a linux-based shell running in a windows environment?

musm · 2019-10-05T04:03:41Z

base/shell.jl

+function print_shell_escaped_BATCHly(io::IO, arg::AbstractString)
+    # see https://www.robvanderwoude.com/variableexpansion.php
+    # the rule for ! is a bit esoteric, but doesn't hurt to add it
+    any(in("\r\n"), arg) && throw("Encountered unsupported character by CMD")


make this an ArgumentError error? same for above

vtjnash · 2019-10-05T04:13:39Z

base/shell.jl

+
+function print_shell_escaped_BATCHly(io::IO, arg::AbstractString)
+    # see https://www.robvanderwoude.com/variableexpansion.php
+    # the rule for ! is a bit esoteric, but doesn't hurt to add it


I think that's just because folks are bad at it. It seems clearly part of the list to me. Some sources list ( and ), but—as explained in https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts—they are not needed. Nor is @, as is claimed by this otherwise fairly good source: http://daviddeley.com/autohotkey/parameters/parameters.htm#WINCMDRULES

base/shell.jl

musm · 2019-10-14T03:02:50Z

base/shell.jl

+
+function print_shell_escaped_PWSHly(io::IO, arg::AbstractString)
+    arg = replace(arg, r"[\$#;]" => s"`\0")
+    arg = replace(arg, r"[\"|\\\\(?=\\\\*(\"|$))]" => s"\\\0")


https://stackoverflow.com/questions/44981177/run-powershell-custom-function-in-new-window/44986341#44986341

It seems like since we are launching the process from a start-process we need to additionally escaping " and \ using this regex, which is described in the excellent stackoverflow answer.

That left me even more confused. It ends with but it’s not this simple, and the rules have changed over time.

One thing I’m fairly confident of is that this pwsh function needs us to add \r and \n to the winsomely whitespace list to pass through correctly here (no effect if it doesn’t go to pwsh, so might as well always do it there).

One thing I’m fairly confident of is that this pwsh function needs us to add \r and \n to the winsomely whitespace list to pass through correctly here (no effect if it doesn’t go to pwsh, so might as well always do it there).

Why's that?

I thought we needed powershell to work for this example

shell> gci C:\\Program\ Files

Note

julia> Base.shell_escape_winsomely(Base.shell_split("gci C:\\\\Program\\ Files")...) |>print gci "C:\Program Files"

Running
gci "C:\Program Files" in a powershell environment works. But not in julia unless we
do the additional escaping so that powershell interprets the command as a single string.
arg = replace(arg, r"[\"|\\\\(?=\\\\*(\"|$))]" => s"\\\0")

@vtjnash Please see

The string needs escaping, however, in order to be passed to the new Powershell process unmodified.
" instances embedded in the string are stripped, unless they are either represented as " or tripled (""").
(" rather than the usual `" is needed to escape double quotes in this case, because PowerShell expects " when passing a command to the powershell.exe executable.)

I feel confident that we now have a correct escaping solution to powershell and also for CMD

I wasn't sure what your source was for gci, so I wrote a simple one to be able to inspect what reaches the target application. Save as gci.c, compile with cc gci.c, then run as a.exe.

#include <windows.h> #include <stdio.h> int main (int argc, char **argv) { printf("%s\n", GetCommandLineA()); for (int i = 0; i < argc; i++) { printf("%d: %s\n", i, argv[i]); } }

musm · 2019-10-14T03:04:10Z

base/shell.jl

+shell_escape_CMDly(arg::AbstractString) = sprint(print_shell_escaped_CMDly, arg)
+
+function print_shell_escaped_PWSHly(io::IO, arg::AbstractString)
+    arg = replace(arg, r"[\$#;]" => s"`\0")


\$ prevents powershell variables, ; prevents executing two commands, # escapes comment character

Suggested change

arg = replace(arg, r"[\$#;]" => s"`\0")

arg = replace(arg, r"[`\"\$#;|><&(){}=]" => s"`\0")

(eg. see expanded list at https://www.red-gate.com/simple-talk/wp-content/uploads/imported/2264-PS%20Quoting%20Wallchart_1_0_1.pdf, although I haven't yet found the case where = is special, the rest are certainly good here)

hm, I think it additionally also needs "\r" => "`r", "\n" => "`n", "\t" => "`t"

musm · 2019-10-14T04:11:54Z

There was a bug here when someone passed ENV["JULIA_SHELL"] = "", which is fixed here by also defaulting this case to either sh or cmd.

musm · 2019-10-14T04:12:08Z

@vtjnash how does this PR look now?

musm · 2019-10-15T18:46:20Z

Ok so I feel like I have finally converged to a solution here, and this should be ready for final review.

musm · 2019-10-15T19:11:56Z

My only question to @vtjnash is why do you feel like we also need to quote \r and \n in the print_shell_escaped_winsomely function?

musm · 2019-10-15T19:13:33Z

Should we default to CMD on Windows OR powershell with -noProfile ?

vtjnash · 2019-10-15T20:01:21Z

base/shell.jl

+shell_escape_CMDly(arg::AbstractString) = sprint(print_shell_escaped_CMDly, arg)
+
+function print_shell_escaped_PWSHly(io::IO, arg::AbstractString)
+    arg = replace(arg, r"[\$#;]" => s"`\0")


Suggested change

arg = replace(arg, r"[\$#;]" => s"`\0")

arg = replace(arg, r"[`\"\$#;|><&(){}=]" => s"`\0")

(eg. see expanded list at https://www.red-gate.com/simple-talk/wp-content/uploads/imported/2264-PS%20Quoting%20Wallchart_1_0_1.pdf, although I haven't yet found the case where = is special, the rest are certainly good here)

vtjnash · 2019-10-15T20:01:48Z

base/client.jl

+                command = Cmd(`$shell /c $(shell_escape_CMDly(shell_escape_winsomely(cmd)))`, windows_verbatim=true)
+            elseif shell_name in ("powershell", "pwsh")
+                # enclose in double quotes to enusre we prevent whitespace normalization
+                command = Cmd(`$shell -Command "$(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`, windows_verbatim=true)


Suggested change

command = Cmd(`$shell -Command "$(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`, windows_verbatim=true)

command = Cmd(`$shell -Command "& $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`)

Although this is only correct so long as powershell is a no-op though. If something is getting intercepted by powershell, we need to use completely different rules. Something like:

Suggested change

command = Cmd(`$shell -Command "$(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`, windows_verbatim=true)

CommandType = read(`powershell -Command "Get-Command -- $(shell_escape_PWSH_cmdlet_ly(cmd.exec[1])) | Select-Object -ExpandProperty CommandType"`, String)

# TODO: while CommandType == "Alias"; CommandType = ...; end

if CommandType == "Application"

command = Cmd(`$shell -Command "& $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`)

else # handle Function and Cmdlet # TODO: what is the proper handling for the other types (ExternalScript, Script, Workflow, Configuration, and Filter)

command = Cmd(`$shell -Command "& $(shell_escape_PWSH_cmdlet_ly(cmd))"`)

end

vtjnash · 2019-10-15T20:08:08Z

base/shell.jl

+    # Similarily, if the string as a whole or a double-quoted string inside the function body
+    # ends in a non-empty run of \, that \ would be interpreted
+    # as a an escape character so \ must be doubled
+    arg = replace(arg, r"\"|\\(?=\\*(\"|$))" => s"\\\0")


I think this is all mistaken and false. I think I understand where it's coming from, it just doesn't match the behavior I observe in my testing for this stage in the pipeline.

Suggested change

arg = replace(arg, r"\"|\\(?=\\*(\"|$))" => s"\\\0")

vtjnash · 2019-10-15T20:28:58Z

base/shell.jl

+
+See also [`shell_escape_CMDly`](@ref).
+"""
+shell_escape_PWSHly(arg::AbstractString) = sprint(print_shell_escaped_PWSHly, arg)


Here's my suggested source for the PWSH_cmdlet_ly function I mention above:

Suggested change

shell_escape_PWSHly(arg::AbstractString) = sprint(print_shell_escaped_PWSHly, arg)

shell_escape_PWSHly(arg::AbstractString) = sprint(print_shell_escaped_PWSHly, arg)

function print_shell_escaped_PWSH_cmdlet_ly(io::IO, args::AbstractString...)

# often the shortest way to escape a powershell string is to double any single quotes and then wrap the whole thing in single quotes (alternatively, we could prefix all the non-word characters with a back-tick and replace newlines with \`r and \`n)

# but skip the escaping for common cases we always know are safe (e.g. so that named parameters are typically still interpreted correctly)

isword(c::AbstractChar) = '0' <= c <= '9' || 'a' <= c <= 'z' || 'A' <= c <= 'Z' || c == '_' || c == '\\' || c == ':' || c == '/' || c == '-'

join(io, (all(isword, arg) ? arg : "'" * replace(arg, "'" => "''") * "'" for arg in args), " ")

end

"""

shell_escape_PWSH_cmdlet_ly(args::AbstractString...) -> String

Escapes special characters so they can be appropriately used with a PowerShell cmdlet (such as `echo`).

See also [`shell_escape_PWSHly`](@ref) and [`shell_escape_winsomely`](@ref).

"""

print_shell_escaped_PWSH_cmdlet_ly(io::IO, args::AbstractString...)

vtjnash · 2019-10-15T21:18:55Z

base/shell.jl

+shell_escape_CMDly(arg::AbstractString) = sprint(print_shell_escaped_CMDly, arg)
+
+function print_shell_escaped_PWSHly(io::IO, arg::AbstractString)
+    arg = replace(arg, r"[\$#;]" => s"`\0")


hm, I think it additionally also needs "\r" => "`r", "\n" => "`n", "\t" => "`t"

vtjnash · 2019-10-15T21:41:00Z

base/shell.jl

+
+function print_shell_escaped_PWSHly(io::IO, arg::AbstractString)
+    arg = replace(arg, r"[\$#;]" => s"`\0")
+    arg = replace(arg, r"[\"|\\\\(?=\\\\*(\"|$))]" => s"\\\0")


I wasn't sure what your source was for gci, so I wrote a simple one to be able to inspect what reaches the target application. Save as gci.c, compile with cc gci.c, then run as a.exe.

#include <windows.h> #include <stdio.h> int main (int argc, char **argv) { printf("%s\n", GetCommandLineA()); for (int i = 0; i < argc; i++) { printf("%d: %s\n", i, argv[i]); } }

musm · 2019-10-21T18:49:56Z

We should probably also allow pwsh on Linux and MacOS since Powershell Core is cross-platform

Introduce REPL shell mode on Windows. Co-authored-by: Mustafa M. <[email protected]> Co-authored-by: Jameson Nash <[email protected]>

stevengj · 2019-11-25T16:07:48Z

base/client.jl

            if shell_name == "fish"
                shell_escape_cmd = "begin; $(shell_escape_posixly(cmd)); and true; end"
+                command = `$shell -c $shell_escape_cmd`
+            elseif shell_name == "pwsh"
+                command = _powershell_execute(shell, cmd)


Doesn't this do the wrong escaping on Unix?

(I'm not sure it's worth the effort to support pwsh on Unix. This is only used for interactive mode, after all.)

Powershell's handling of arguments is known (PowerShell/PowerShell#1995) to be buggy, so can't reliably be used for launching programs anyways.

@vtjnash, that's argument handling on Windows. Presumably on Unix systems pwsh just uses *argv, no? I guess some amount of escaping is still needed for passing arguments through to subprocesses, but possibly the same problem does not appear on Unix because there is no CommandLineToArgvW layer.

Sadly, no (e.g. PowerShell/PowerShell#10440)

no CommandLineToArgvW layer

Sadly, it is currently present (although both broken and undocumented—and eventually supposed to be unnecessary)

musm · 2019-12-10T06:11:19Z

should we try to get this in, in some form before feature freze?

StefanKarpinski · 2019-12-10T14:59:07Z

It is ready for re-review by @vtjnash and/or @stevengj then?

vtjnash

Can you remove all of the powershell-related content? The rest I think seems ready to go. We should add the powershell portions in a pair of followup PRs (one to add the shell_escape_PWSHly layer and one to use it in the REPL)

vtjnash · 2019-12-11T17:29:23Z

base/client.jl

+                command = Cmd(`$shell /c $(shell_escape_CMDly(shell_escape_winsomely(cmd)))`, windows_verbatim=true)
+            elseif shell_name in ("powershell", "pwsh")
+                command = Cmd(`$shell -Command $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))`, windows_verbatim=true)
+            elseif shell_name == "busybox"


I think we should make this the else block

vtjnash · 2019-12-11T17:33:13Z

base/shell.jl

+    run(Cmd(Cmd(["cmd /c \"break | echo \$(shell_escape_CMDly(shell_escape_CMDly(to_print)))"]), windows_verbatim=true))
+    ```
+"""
+shell_escape_CMDly(arg::AbstractString) = sprint(print_shell_escaped_CMDly, arg)


This appears to need tests. Also, can you split this aspect into a separate commit?

musm · 2019-12-11T17:39:46Z

Can you remove all of the powershell-related content? The rest I think seems ready to go. We should add the powershell portions in a pair of followup PRs (one to add the shell_escape_PWSHly layer and one to use it in the REPL)

I think I'll just open a seperate PR with the suggestions

vtjnash · 2019-12-16T20:20:59Z

base/shell.jl

+function print_shell_escaped_CMDly(io::IO, arg::AbstractString)
+    any(c -> c in ('\r', '\n'), arg) && throw(ArgumentError("Encountered unsupported character by CMD."))
+    # include " so to avoid toggling behavior of ^
+    arg = replace(arg, r"[%!^\"<>&|]" => s"^\0")


Suggested change

arg = replace(arg, r"[%!^\"<>&|]" => s"^\0")

arg = replace(arg, r"[%)!^\"<>&|]" => s"^\0")

Upon closer inspection of https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts/4095133#4095133, I realized that ) is a metacharacter even though ( is not. (or we can include both here for symmetry)

musm · 2020-07-16T17:01:15Z

I'm looking back at this PR and I really dread to revisit this PR 😆😆.

PowerShell's handling of external arguments is so borked that the only reasonable solution is to use the iep script in PowerShell/PowerShell#1995 (comment) and for newer Powershell versions wait for PowerShell/PowerShell#13068 to be merged

StefanKarpinski · 2020-07-16T17:44:24Z

Counter-proposal: do the same thing on Windows as we do everywhere else, i.e. just exec the cmd that's entered, but ship with busybox tools on Windows and put the path to the busybox tools in the PATH before evaluating shell mode commands. I feel like that will make many examples work on Windows in the same way they do on UNIX and doesn't require radically changing the way this works on only one platform.

Also: It would be great (and has been on my todo list for so long) to implement | and other POSIX shell features in Cmd syntax, in which case the shell mode would automatically get completely cross-platform support for a lot of shell-like features. Combine that with having the busybox tools on Windows and you might not even notice that you're not running on UNIX!

stevengj · 2021-02-18T18:42:00Z

ship with busybox tools on Windows and put the path to the busybox tools in the PATH before evaluating shell mode commands.

Or just put the path to busybox tools in the PATH for all Cmd evaluations?

musm · 2021-04-28T14:43:06Z

Closing as stale. I'll look at opening a new PR when I find a more satisfactory solution. Shipping busybox is reverting back to something that we removed and suboptimal (even though what we have currently is worse). Powershell folks have been trying to work around some issues with calling external commands. We updated some the cmd escaping rules, so I think we can update to that in another PR. We might have to limit the powershell option to newer powershell versions and perhaps use bash through WSL if that's available.

musm force-pushed the shellmodewin branch from 958be38 to c60ba50 Compare October 5, 2019 03:36

musm commented Oct 5, 2019

View reviewed changes

musm force-pushed the shellmodewin branch from e98b07d to 1441247 Compare October 5, 2019 03:58

musm commented Oct 5, 2019

View reviewed changes

vtjnash reviewed Oct 5, 2019

View reviewed changes

base/shell.jl Outdated Show resolved Hide resolved

musm force-pushed the shellmodewin branch 5 times, most recently from 5e5694a to 083cb4a Compare October 11, 2019 23:35

ViralBShah added the system:windows Affects only Windows label Oct 12, 2019

musm changed the title ~~REPL shell mode for Windows~~ REPL shell mode for Windows WIP Oct 12, 2019

musm changed the title ~~REPL shell mode for Windows WIP~~ REPL shell mode for Windows Oct 14, 2019

musm commented Oct 14, 2019

View reviewed changes

musm force-pushed the shellmodewin branch from 51e7c81 to eaebcac Compare October 14, 2019 14:42

vtjnash reviewed Oct 15, 2019

View reviewed changes

musm force-pushed the shellmodewin branch 4 times, most recently from 6b46b98 to 0dfcedd Compare October 21, 2019 19:25

musm force-pushed the shellmodewin branch 2 times, most recently from 8f2b093 to 164f274 Compare October 21, 2019 19:29

REPL shell mode for Windows

aa8a49e

Introduce REPL shell mode on Windows. Co-authored-by: Mustafa M. <[email protected]> Co-authored-by: Jameson Nash <[email protected]>

musm force-pushed the shellmodewin branch from 164f274 to aa8a49e Compare October 21, 2019 19:33

musm added 2 commits October 21, 2019 15:36

fixes

614e13d

fixes

8a3c847

stevengj reviewed Nov 25, 2019

View reviewed changes

Merge branch 'master' into shellmodewin

09c1d61

vtjnash reviewed Dec 11, 2019

View reviewed changes

vtjnash mentioned this pull request Dec 16, 2019

Refactor shell_escape_winsomely() and add escaping function for CMD.EXE syntax #34111

Closed

vtjnash reviewed Dec 16, 2019

View reviewed changes

musm closed this Apr 28, 2021

	arg = replace(arg, r"[\$#;]" => s"`\0")
	arg = replace(arg, r"[`\"\$#;\|><&(){}=]" => s"`\0")

	command = Cmd(`$shell -Command "$(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`, windows_verbatim=true)
	command = Cmd(`$shell -Command "& $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`)

-                command = Cmd(`$shell -Command "$(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`, windows_verbatim=true)
+CommandType = read(`powershell -Command "Get-Command -- $(shell_escape_PWSH_cmdlet_ly(cmd.exec[1])) | Select-Object -ExpandProperty CommandType"`, String)
+# TODO: while CommandType == "Alias"; CommandType = ...; end
+if CommandType == "Application"
+    command = Cmd(`$shell -Command "& $(shell_escape_PWSHly(shell_escape_winsomely(cmd)))"`)
+else # handle Function and Cmdlet # TODO: what is the proper handling for the other types (ExternalScript, Script, Workflow, Configuration, and Filter)
+    command = Cmd(`$shell -Command "& $(shell_escape_PWSH_cmdlet_ly(cmd))"`)
+end

-shell_escape_PWSHly(arg::AbstractString) = sprint(print_shell_escaped_PWSHly, arg)
+shell_escape_PWSHly(arg::AbstractString) = sprint(print_shell_escaped_PWSHly, arg)
+function print_shell_escaped_PWSH_cmdlet_ly(io::IO, args::AbstractString...)
+    # often the shortest way to escape a powershell string is to double any single quotes and then wrap the whole thing in single quotes (alternatively, we could prefix all the non-word characters with a back-tick and replace newlines with \`r and \`n)
+    # but skip the escaping for common cases we always know are safe (e.g. so that named parameters are typically still interpreted correctly)
+    isword(c::AbstractChar) = '0' <= c <= '9' || 'a' <= c <= 'z' || 'A' <= c <= 'Z' || c == '_' || c == '\\' || c == ':' || c == '/' || c == '-'
+    join(io, (all(isword, arg) ? arg : "'" * replace(arg, "'" => "''") * "'" for arg in args), " ")
+end
+"""
+      shell_escape_PWSH_cmdlet_ly(args::AbstractString...) -> String
+ Escapes special characters so they can be appropriately used with a PowerShell cmdlet (such as `echo`).
+ See also [`shell_escape_PWSHly`](@ref) and [`shell_escape_winsomely`](@ref).
+ """
+print_shell_escaped_PWSH_cmdlet_ly(io::IO, args::AbstractString...)

	arg = replace(arg, r"[%!^\"<>&\|]" => s"^\0")
	arg = replace(arg, r"[%)!^\"<>&\|]" => s"^\0")

		include("regex.jl")
		include("shell.jl")

REPL shell mode for Windows #33474

REPL shell mode for Windows #33474

Conversation

musm commented Oct 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm Oct 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm Oct 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm Oct 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm Oct 14, 2019 • edited Loading

Choose a reason for hiding this comment

musm Oct 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm commented Oct 14, 2019

musm commented Oct 14, 2019

musm commented Oct 15, 2019

musm commented Oct 15, 2019

musm commented Oct 15, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm commented Oct 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stevengj Nov 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm commented Dec 10, 2019

StefanKarpinski commented Dec 10, 2019

vtjnash left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

musm commented Dec 11, 2019

Choose a reason for hiding this comment

musm commented Jul 16, 2020

StefanKarpinski commented Jul 16, 2020

stevengj commented Feb 18, 2021

musm commented Apr 28, 2021

musm commented Oct 4, 2019 •

edited

Loading

musm Oct 5, 2019 •

edited

Loading

musm Oct 5, 2019 •

edited

Loading

musm Oct 14, 2019 •

edited

Loading

musm Oct 14, 2019 •

edited

Loading

musm Oct 14, 2019 •

edited

Loading

stevengj Nov 25, 2019 •

edited

Loading