[WIP] REPL shell mode for windows #21294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update repl_cmd()
ararslan
reviewed
Apr 6, 2017
| shell = shell_split(get(ENV,"JULIA_SHELL",get(ENV,"SHELL","/bin/sh"))) | ||
| shell_name = Base.basename(shell[1]) | ||
| function repl_cmd(line::AbstractString, out) | ||
| if is_windows() |
There was a problem hiding this comment.
Should use @static when conditioning on the OS inside a function
There was a problem hiding this comment.
not unless you're emitting code that doesn't compile on multiple platforms, or you really need to eliminate the comparison for runtime performance. better to leave the static out if neither is the case, have all branches at least get compiled.
There was a problem hiding this comment.
I think on v0.6, code is conditionally compiled with and without @static
So maybe there's no runtime performance difference?
Both test1() and test2() produce the same llvm:
test1() = is_windows() ? 1 : "a"
test2() = @static is_windows() ? 1 : "a"
julia> @code_llvm test1()
; Function Attrs: uwtable
define i64 @julia_test1_68517() #0 !dbg !5 {
top:
ret i64 1
}
julia> @code_llvm test2()
; Function Attrs: uwtable
define i64 @julia_test2_68518() #0 !dbg !5 {
top:
ret i64 1
}
ararslan
added
REPL
|
Bump — would be nice to see this merged in some form. |
|
Replaced by #23703 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 for #20776
(I made a mistake with GitHub when trying to modify that PR, sorry)
Summary:
JULIA_SHELLcan be set to:cmdis default for Windows users.For Windows, the raw line is processed, rather than converting to
Cmdand then re-assembling into a Windows command line. Windows shell commands are passed as a string anyway, so this gives the user more control over any escaping. I think it works quite well.Modified special handling of
cd. When there are 2 or more arguments, command line is processed as normal, rather than throwing an error. This allows commands such ascd $dir && $commandto be executed.