Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LinearAlgebra deprecations #28456

Merged
merged 2 commits into from
Aug 6, 2018
Merged

remove LinearAlgebra deprecations #28456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b84ab4
Remove LinearAlgebra deprecations.
Sacha0 Aug 5, 2018
b9d599f
update variable names
fredrikekre Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions base/deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,36 +692,6 @@ finalizer(f::Ptr{Cvoid}, o::Function) = invoke(finalizer, Tuple{Ptr{Cvoid}, Any}
Base.@deprecate_binding broadcast_t broadcast false ", `broadcast_t(f, ::Type{ElType}, shape, iter, As...)` should become `broadcast(f, Broadcast.DefaultArrayStyle{N}(), ElType, shape, As...))` (see the manual chapter Interfaces)"
end


### deprecations for lazier, less jazzy linalg transition in the next several blocks ###
# TODOs re. .' deprecation
# (1) remove .' deprecation from src/julia-syntax.scm around line 2346
# (2) remove .' documentation from base/docs/basedocs.jl around line 255
# (3) remove .'-involving code from base/show.jl around line 1277
# (4) remove .'-involving test from test/deprecation_exec.jl around line 178
# (5) remove .'-related code from src/ast.scm and src/julia-parser.scm

# A[ct]_(mul|ldiv|rdiv)_B[ct][!] methods from base/operators.jl, to deprecate
@deprecate Ac_ldiv_Bt(a,b) (\)(adjoint(a), transpose(b))
@deprecate At_ldiv_Bt(a,b) (\)(transpose(a), transpose(b))
@deprecate A_ldiv_Bt(a,b) (\)(a, transpose(b))
@deprecate At_ldiv_B(a,b) (\)(transpose(a), b)
@deprecate Ac_ldiv_Bc(a,b) (\)(adjoint(a), adjoint(b))
@deprecate A_ldiv_Bc(a,b) (\)(a, adjoint(b))
@deprecate Ac_ldiv_B(a,b) (\)(adjoint(a), b)
@deprecate At_rdiv_Bt(a,b) (/)(transpose(a), transpose(b))
@deprecate A_rdiv_Bt(a,b) (/)(a, transpose(b))
@deprecate At_rdiv_B(a,b) (/)(transpose(a), b)
@deprecate Ac_rdiv_Bc(a,b) (/)(adjoint(a), adjoint(b))
@deprecate A_rdiv_Bc(a,b) (/)(a, adjoint(b))
@deprecate Ac_rdiv_B(a,b) (/)(adjoint(a), b)
@deprecate At_mul_Bt(a,b) (*)(transpose(a), transpose(b))
@deprecate A_mul_Bt(a,b) (*)(a, transpose(b))
@deprecate At_mul_B(a,b) (*)(transpose(a), b)
@deprecate Ac_mul_Bc(a,b) (*)(adjoint(a), adjoint(b))
@deprecate A_mul_Bc(a,b) (*)(a, adjoint(b))
@deprecate Ac_mul_B(a,b) (*)(adjoint(a), b)

# issue #24822
@deprecate_binding Display AbstractDisplay

Expand Down
20 changes: 0 additions & 20 deletions base/docs/basedocs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,26 +257,6 @@ julia> A'
"""
kw"'"

"""
.'

The transposition operator, see [`transpose`](@ref).

# Examples
```jldoctest
julia> A = [1.0 -2.0im; 4.0im 2.0]
2×2 Array{Complex{Float64},2}:
1.0+0.0im -0.0-2.0im
0.0+4.0im 2.0+0.0im

julia> A.'
2×2 Array{Complex{Float64},2}:
1.0+0.0im 0.0+4.0im
-0.0-2.0im 2.0+0.0im
```
"""
kw".'"

"""
const

Expand Down
2 changes: 1 addition & 1 deletion base/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,7 +1401,7 @@ function show_unquoted(io::IO, ex::Expr, indent::Int, prec::Int)
parens && print(io, ")")

# transpose
elseif (head === Symbol('\'') || head === Symbol(".'")) && length(args) == 1
elseif head === Symbol('\'') && length(args) == 1
if isa(args[1], Symbol)
show_unquoted(io, args[1])
else
Expand Down
140 changes: 0 additions & 140 deletions base/sysimg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,146 +707,6 @@ end
@deprecate_stdlib speye SparseArrays true

# PR #25571: LinearAlgebra to stdlib
@deprecate_stdlib BLAS LinearAlgebra true
## functions that were re-exported from Base
@deprecate_stdlib bkfact! LinearAlgebra true
@deprecate_stdlib bkfact LinearAlgebra true
@deprecate_stdlib chol LinearAlgebra true
@deprecate_stdlib cholfact! LinearAlgebra true
@deprecate_stdlib cholfact LinearAlgebra true
@deprecate_stdlib cond LinearAlgebra true
@deprecate_stdlib condskeel LinearAlgebra true
@deprecate_stdlib cross LinearAlgebra true
@deprecate_stdlib adjoint! LinearAlgebra true
# @deprecate_stdlib adjoint LinearAlgebra true
@deprecate_stdlib det LinearAlgebra true
@deprecate_stdlib diag LinearAlgebra true
@deprecate_stdlib diagind LinearAlgebra true
@deprecate_stdlib diagm LinearAlgebra true
@deprecate_stdlib dot LinearAlgebra true
@deprecate_stdlib eig LinearAlgebra true
@deprecate_stdlib eigfact! LinearAlgebra true
@deprecate_stdlib eigfact LinearAlgebra true
@deprecate_stdlib eigmax LinearAlgebra true
@deprecate_stdlib eigmin LinearAlgebra true
@deprecate_stdlib eigvals LinearAlgebra true
@deprecate_stdlib eigvals! LinearAlgebra true
@deprecate_stdlib eigvecs LinearAlgebra true
@deprecate_stdlib factorize LinearAlgebra true
@deprecate_stdlib givens LinearAlgebra true
@deprecate_stdlib hessfact! LinearAlgebra true
@deprecate_stdlib hessfact LinearAlgebra true
@deprecate_stdlib isdiag LinearAlgebra true
@deprecate_stdlib ishermitian LinearAlgebra true
@deprecate_stdlib isposdef! LinearAlgebra true
@deprecate_stdlib isposdef LinearAlgebra true
@deprecate_stdlib issymmetric LinearAlgebra true
@deprecate_stdlib istril LinearAlgebra true
@deprecate_stdlib istriu LinearAlgebra true
# @deprecate_stdlib kron LinearAlgebra true
@deprecate_stdlib ldltfact LinearAlgebra true
@deprecate_stdlib ldltfact! LinearAlgebra true
@deprecate_stdlib logabsdet LinearAlgebra true
@deprecate_stdlib logdet LinearAlgebra true
@deprecate_stdlib lu LinearAlgebra true
@deprecate_stdlib lufact! LinearAlgebra true
@deprecate_stdlib lufact LinearAlgebra true
@deprecate_stdlib lyap LinearAlgebra true
@deprecate_stdlib norm LinearAlgebra true
@deprecate_stdlib normalize LinearAlgebra true
@deprecate_stdlib normalize! LinearAlgebra true
@deprecate_stdlib nullspace LinearAlgebra true
@deprecate_stdlib ordschur! LinearAlgebra true
@deprecate_stdlib ordschur LinearAlgebra true
@deprecate_stdlib pinv LinearAlgebra true
@deprecate_stdlib qr LinearAlgebra true
@deprecate_stdlib qrfact! LinearAlgebra true
@deprecate_stdlib qrfact LinearAlgebra true
@deprecate_stdlib lq LinearAlgebra true
@deprecate_stdlib lqfact! LinearAlgebra true
@deprecate_stdlib lqfact LinearAlgebra true
@deprecate_stdlib rank LinearAlgebra true
@deprecate_stdlib scale! LinearAlgebra true
@deprecate_stdlib schur LinearAlgebra true
@deprecate_stdlib schurfact! LinearAlgebra true
@deprecate_stdlib schurfact LinearAlgebra true
@deprecate_stdlib svd LinearAlgebra true
@deprecate_stdlib svdfact! LinearAlgebra true
@deprecate_stdlib svdfact LinearAlgebra true
@deprecate_stdlib svdvals! LinearAlgebra true
@deprecate_stdlib svdvals LinearAlgebra true
@deprecate_stdlib sylvester LinearAlgebra true
@deprecate_stdlib trace LinearAlgebra true tr
@deprecate_stdlib transpose! LinearAlgebra true
# @deprecate_stdlib transpose LinearAlgebra true
@deprecate_stdlib tril! LinearAlgebra true
@deprecate_stdlib tril LinearAlgebra true
@deprecate_stdlib triu! LinearAlgebra true
@deprecate_stdlib triu LinearAlgebra true
@deprecate_stdlib vecdot LinearAlgebra true
@deprecate_stdlib vecnorm LinearAlgebra true
@deprecate_stdlib $(:⋅) LinearAlgebra true
@deprecate_stdlib $(:×) LinearAlgebra true

## types that were re-exported from Base
@deprecate_stdlib Diagonal LinearAlgebra true
@deprecate_stdlib Bidiagonal LinearAlgebra true
@deprecate_stdlib Tridiagonal LinearAlgebra true
@deprecate_stdlib SymTridiagonal LinearAlgebra true
@deprecate_stdlib UpperTriangular LinearAlgebra true
@deprecate_stdlib LowerTriangular LinearAlgebra true
@deprecate_stdlib Symmetric LinearAlgebra true
@deprecate_stdlib Hermitian LinearAlgebra true
@deprecate_stdlib Factorization LinearAlgebra true
@deprecate_stdlib UniformScaling LinearAlgebra true
@deprecate_stdlib Adjoint LinearAlgebra true
@deprecate_stdlib Transpose LinearAlgebra true

## functions that were exported from Base.LinAlg but not from Base
@deprecate_stdlib axpy! LinearAlgebra false
@deprecate_stdlib axpby! LinearAlgebra false
@deprecate_stdlib copy_transpose! LinearAlgebra false
@deprecate_stdlib issuccess LinearAlgebra false
@deprecate_stdlib transpose_type LinearAlgebra false
@deprecate_stdlib A_mul_B! LinearAlgebra false
@deprecate_stdlib A_mul_Bt! LinearAlgebra false
@deprecate_stdlib At_mul_B! LinearAlgebra false
@deprecate_stdlib At_mul_Bt! LinearAlgebra false
@deprecate_stdlib A_mul_Bc! LinearAlgebra false
@deprecate_stdlib Ac_mul_B! LinearAlgebra false
@deprecate_stdlib Ac_mul_Bc! LinearAlgebra false
@deprecate_stdlib A_ldiv_B! LinearAlgebra false
@deprecate_stdlib At_ldiv_B! LinearAlgebra false
@deprecate_stdlib Ac_ldiv_B! LinearAlgebra false

## types that were exported from Base.LinAlg but not from Base
@deprecate_stdlib BunchKaufman LinearAlgebra false
@deprecate_stdlib Cholesky LinearAlgebra false
@deprecate_stdlib CholeskyPivoted LinearAlgebra false
@deprecate_stdlib Eigen LinearAlgebra false
@deprecate_stdlib GeneralizedEigen LinearAlgebra false
@deprecate_stdlib GeneralizedSVD LinearAlgebra false
@deprecate_stdlib GeneralizedSchur LinearAlgebra false
@deprecate_stdlib Hessenberg LinearAlgebra false
@deprecate_stdlib LU LinearAlgebra false
@deprecate_stdlib LDLt LinearAlgebra false
@deprecate_stdlib QR LinearAlgebra false
@deprecate_stdlib QRPivoted LinearAlgebra false
@deprecate_stdlib LQ LinearAlgebra false
@deprecate_stdlib Schur LinearAlgebra false
@deprecate_stdlib SVD LinearAlgebra false

## deprecated functions that are moved to stdlib/LinearAlgebra/src/deprecated.jl
@deprecate_stdlib eye LinearAlgebra true
@deprecate_stdlib sqrtm LinearAlgebra true
@deprecate_stdlib expm LinearAlgebra true
@deprecate_stdlib expm! LinearAlgebra true
@deprecate_stdlib logm LinearAlgebra true
@deprecate_stdlib gradient LinearAlgebra true
@deprecate_stdlib ConjArray LinearAlgebra true
@deprecate_stdlib ConjVector LinearAlgebra true
@deprecate_stdlib ConjMatrix LinearAlgebra true
@deprecate_stdlib RowVector LinearAlgebra true

# PR #25021
@deprecate_stdlib normalize_string Unicode true
Expand Down
2 changes: 1 addition & 1 deletion src/ast.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
(deparse (cadr (cadr (caddr e)))))
(else
(string #\( (deparse (caddr e)) #\))))))
((memq (car e) '(... |'| |.'|))
((memq (car e) '(... |'|))
(string (deparse (cadr e)) (car e)))
((or (syntactic-op? (car e)) (eq? (car e) '|<:|) (eq? (car e) '|>:|))
(if (length= e 2)
Expand Down
2 changes: 0 additions & 2 deletions stdlib/LinearAlgebra/src/LinearAlgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,6 @@ copy_oftype(A::AbstractArray{T,N}, ::Type{S}) where {T,N,S} = convert(AbstractAr

include("adjtrans.jl")
include("transpose.jl")
include("conjarray.jl")
include("rowvector.jl")

include("exceptions.jl")
include("generic.jl")
Expand Down
20 changes: 3 additions & 17 deletions stdlib/LinearAlgebra/src/bidiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,26 +194,12 @@ similar(B::Bidiagonal, ::Type{T}) where {T} = Bidiagonal(similar(B.dv, T), simil

#Singular values
svdvals!(M::Bidiagonal{<:BlasReal}) = LAPACK.bdsdc!(M.uplo, 'N', M.dv, M.ev)[1]
function svd!(M::Bidiagonal{<:BlasReal}; full::Bool = false, thin::Union{Bool,Nothing} = nothing)
# DEPRECATION TODO: remove deprecated thin argument and associated logic after 0.7
if thin != nothing
Base.depwarn(string("the `thin` keyword argument in `svd!(A; thin = $(thin))` has ",
"been deprecated in favor of `full`, which has the opposite meaning, ",
"e.g. `svd!(A; full = $(!thin))`."), :svd!)
full::Bool = !thin
end
function svd!(M::Bidiagonal{<:BlasReal}; full::Bool = false)
d, e, U, Vt, Q, iQ = LAPACK.bdsdc!(M.uplo, 'I', M.dv, M.ev)
SVD(U, d, Vt)
end
function svd(M::Bidiagonal; full::Bool = false, thin::Union{Bool,Nothing} = nothing)
# DEPRECATION TODO: remove deprecated thin argument and associated logic after 0.7
if thin != nothing
Base.depwarn(string("the `thin` keyword argument in `svd(A; thin = $(thin))` has ",
"been deprecated in favor of `full`, which has the opposite meaning, ",
"e.g. `svd(A; full = $(!thin))`."), :svd)
full::Bool = !thin
end
return svd!(copy(M), full = full)
function svd(M::Bidiagonal; full::Bool = false)
svd!(copy(M), full = full)
end

####################
Expand Down
25 changes: 0 additions & 25 deletions stdlib/LinearAlgebra/src/conjarray.jl
View file
Open in desktop

This file was deleted.

Loading