Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LinearAlgebra deprecations #28456

Merged
merged 2 commits into from
Aug 6, 2018
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Aug 5, 2018

Waiting for build to complete locally for testing, but might as well spin the CI roulette wheel now. Best!

@Sacha0 Sacha0 added the linear algebra Linear algebra label Aug 5, 2018
@Sacha0 Sacha0 force-pushed the nixladeps branch 6 times, most recently from 14bcf02 to 4497cfc Compare August 5, 2018 22:23
@Sacha0
Copy link
Member Author

Sacha0 commented Aug 5, 2018

(Now builds locally!)

@Sacha0
Copy link
Member Author

Sacha0 commented Aug 5, 2018

@Keno

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.0.0-DEV.43 (2018-08-05 22:23 UTC)
 _/ |\__'_|_|_|\__'_|  |  nixladeps/4497cfcaa5 (fork: 1 commits, 0 days)
|__/                   |  x86_64-apple-darwin17.7.0

julia> Base.runtests("LinearAlgebra/bidiag")
Test             (Worker) | Time (s) | GC (s) | GC % | Alloc (MB) | RSS (MB)
Illegal inttoptr
	  %scevgep99100 = ptrtoint float addrspace(13)* %scevgep99 to i64
Illegal inttoptr
	  %scevgep102103 = ptrtoint float addrspace(13)* %scevgep102 to i64
Illegal inttoptr
	  %umax104105 = inttoptr i64 %umax to i8 addrspace(13)*
Illegal inttoptr
	  %umax106107 = inttoptr i64 %umax106 to { float, float } addrspace(13)*

signal (6): Abort trap: 6
in expression starting at /Users/sacha/pkg/julia/usr/share/julia/stdlib/v1.0/LinearAlgebra/test/bidiag.jl:13
__pthread_kill at /usr/lib/system/libsystem_kernel.dylib (unknown line)
Allocations: 76234096 (Pool: 76217348; Big: 16748); GC: 167
ERROR: A test has failed. Please submit a bug report (https://github.com/JuliaLang/julia/issues)
including error messages above and the output of versioninfo():
Julia Version 1.0.0-DEV.43
Commit 4497cfcaa5 (2018-08-05 22:23 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin17.7.0)
  CPU: Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, skylake)

Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] #runtests#667(::Int64, ::Bool, ::Nothing, ::Function, ::String) at ./util.jl:734
 [3] runtests(::String) at ./util.jl:721
 [4] top-level scope at none:0

StefanKarpinski added a commit that referenced this pull request Aug 5, 2018
remove LinearAlgebra deprecations
@StefanKarpinski StefanKarpinski added deprecation This change introduces or involves a deprecation and removed deprecation This change introduces or involves a deprecation labels Aug 5, 2018
@fredrikekre
Copy link
Member

Updated some failing tests, should pass now.

@KristofferC KristofferC added this to the 1.0 milestone Aug 6, 2018
@KristofferC
Copy link
Member

Good to go? Circle CI might fail due to running on non-mergecommit .circleci but I think we should ignore that.

@fredrikekre fredrikekre merged commit 00d6f72 into JuliaLang:master Aug 6, 2018
alyst pushed a commit to alyst/julia that referenced this pull request Aug 9, 2018
* Remove LinearAlgebra deprecations.

* update variable names
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
* Remove LinearAlgebra deprecations.

* update variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This change introduces or involves a deprecation linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants