-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow re-importing the same module from different owners #28197
Conversation
If it works, it seems like it should be correct. But maybe should also test the |
|
I get: julia> Profile; using Profile
WARNING: Base.Profile is deprecated, run `using Profile` instead
in module Main
ERROR: importing Profile into Main conflicts with an existing identifier But then every subsequent usage still gives:
|
With this PR? |
No, before the PR. Does this fix it? |
@vtjnash, I now get julia> Profile
WARNING: Base.Profile is deprecated, run `using Profile` instead
in module Main
Profile
julia> using Profile
julia> Profile
WARNING: Base.Profile is deprecated, run `using Profile` instead
in module Main
Profile i.e. it doesn't give an error any more, but it doesn't clear the deprecated flag. I'm not certain under what conditions on |
I'll go ahead and merge this as it seems uncontroversial … additional changes to clear the deprecation flag can go into a separate PR. |
Fixes #28190.