allow re-importing the same module from different owners (#28197)

* allow re-importing the same module from different owners * test
JuliaLang · Jul 23, 2018 · e6f5098 · e6f5098
1 parent 10002fc
commit e6f5098
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/toplevel.c b/src/toplevel.c
@@ -533,7 +533,7 @@ static void import_module(jl_module_t *m, jl_module_t *import)
     jl_binding_t *b;
     if (jl_binding_resolved_p(m, name)) {
         b = jl_get_binding(m, name);
-        if (b->owner != m || (b->value && b->value != (jl_value_t*)import)) {
+        if ((!b->constp && b->owner != m) || (b->value && b->value != (jl_value_t*)import)) {
             jl_errorf("importing %s into %s conflicts with an existing identifier",
                       jl_symbol_name(name), jl_symbol_name(m->name));
         }

diff --git a/test/loading.jl b/test/loading.jl
@@ -552,3 +552,8 @@ append!(empty!(LOAD_PATH), saved_load_path)
 append!(empty!(DEPOT_PATH), saved_depot_path)
 Base.HOME_PROJECT[] = saved_home_project
 Base.ACTIVE_PROJECT[] = saved_active_project
+
+# issue #28190
+module Foo; import Libdl; end
+import .Foo.Libdl; import Libdl
+@test Foo.Libdl === Libdl