fix #22624, crash in certain circular type definitions #22627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
backport pending 0.6
bugfix
tkelman
reviewed
Jun 30, 2017
test/core.jl
Outdated
| # issue #22624, more circular definitions | ||
| struct T22624{A,B,C}; v::Vector{T22624{Int,A}}; end | ||
| let elT = T22624.body.body.body.types[1].parameters[1] | ||
| @test elT == T22624{Int64, T22624.var, C} where C |
This was caused by expanding a type's field types in the wrong environment.
JeffBezanson
force-pushed
the
jb/fix22624
branch
from
0e64f99 to
211e8d1
Compare
ararslan
pushed a commit
that referenced
this pull request
Sep 13, 2017
vtjnash
pushed a commit
that referenced
this pull request
Sep 14, 2017
ararslan
pushed a commit
that referenced
this pull request
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by expanding a type's field types in the wrong environment.