Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash on this circular type definition #22624

Closed
JeffBezanson opened this issue Jun 30, 2017 · 0 comments
Closed

crash on this circular type definition #22624

JeffBezanson opened this issue Jun 30, 2017 · 0 comments
Assignees
@JeffBezanson
Labels
regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch

Comments

@JeffBezanson
Copy link
Member

The following segfaults on 0.6:

julia> struct T{A,B,C}; v::Vector{T{Int,A}}; end

signal (11): Segmentation fault
while loading no file, in expression starting on line 0
inst_type_w_ at /home/jeff/src/julia/src/jltypes.c:1338
inst_all at /home/jeff/src/julia/src/jltypes.c:1272
inst_datatype at /home/jeff/src/julia/src/jltypes.c:1204
inst_type_w_ at /home/jeff/src/julia/src/jltypes.c:1429

I'm working on it and will hopefully have a fix pretty soon.
@JeffBezanson JeffBezanson added regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch labels Jun 30, 2017
@JeffBezanson JeffBezanson self-assigned this Jun 30, 2017
JeffBezanson added a commit that referenced this issue Jun 30, 2017
@JeffBezanson
fix #22624, crash in certain circular type definitions
0e64f99 
This was caused by expanding a type's field types in the wrong
environment.
JeffBezanson added a commit that referenced this issue Jun 30, 2017
@JeffBezanson
Merge pull request #22627 from JuliaLang/jb/fix22624
05719b4 
fix #22624, crash in certain circular type definitions
ararslan pushed a commit that referenced this issue Sep 11, 2017
@JeffBezanson @ararslan
Merge pull request #22627 from JuliaLang/jb/fix22624
b59b38f 
fix #22624, crash in certain circular type definitions

Ref #22627
(cherry picked from commit 05719b4)
ararslan pushed a commit that referenced this issue Sep 13, 2017
@JeffBezanson @ararslan
fix #22624, crash in certain circular type definitions
f8bcac5 
This was caused by expanding a type's field types in the wrong
environment.

Ref #22627
(cherry picked from commit 211e8d1)
vtjnash pushed a commit that referenced this issue Sep 14, 2017
@JeffBezanson @vtjnash
fix #22624, crash in certain circular type definitions
0523e67 
This was caused by expanding a type's field types in the wrong
environment.

Ref #22627
(cherry picked from commit 211e8d1)
ararslan pushed a commit that referenced this issue Sep 15, 2017
@JeffBezanson @ararslan
fix #22624, crash in certain circular type definitions
eb8cbce 
This was caused by expanding a type's field types in the wrong
environment.

Ref #22627
(cherry picked from commit 211e8d1)
martinholters added a commit that referenced this issue Apr 12, 2018
@martinholters
Re-add a fast-path to obviously_unequal to re-fix #22624
8f47a60
martinholters added a commit that referenced this issue Apr 15, 2019
@martinholters
Re-add a fast-path to obviously_unequal to re-fix #22624
b5cb181
@martinholters martinholters mentioned this issue Apr 15, 2019
Merged
martinholters added a commit that referenced this issue Apr 23, 2019
@martinholters
Guard a call to jl_types_equal in inst_datatype_inner
b430127 
For recursive data types, this call could lead to infinite recursion, so
guard it with a special condition to re-fix #22624.
martinholters added a commit that referenced this issue Apr 24, 2019
@martinholters
Guard a call to jl_types_equal in inst_datatype_inner
68191d3 
For recursive data types, this call could lead to infinite recursion, so
guard it with a special condition to re-fix #22624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
regression Regression in behavior compared to a previous version types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeffBezanson