Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken use of Int8 as boolean in codegen test #22506

Merged
merged 1 commit into from
Jun 24, 2017

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jun 24, 2017

0737032 was pushed straight to master without going through CI
or even local testing

0737032 was pushed straight to master without going through CI
or even local testing
@tkelman tkelman force-pushed the tk/fixcodegentest branch from d363535 to 3b702ee Compare June 24, 2017 10:43
@iblislin
Copy link
Member

@tkelman
Copy link
Contributor Author

tkelman commented Jun 24, 2017

Unfortunately no, that only prevents you from force-pushing over something, it doesn't prevent someone who has commit access from pushing to master. That needs to be socially enforced for now (or git hooks or something else opt-in).

@nalimilan
Copy link
Member

Looks like you can restrict push to admins: https://help.github.com/articles/about-branch-restrictions/ That would be a good idea given that we are quite a few to have a contributor status (and our machines could be hacked).

@tkelman
Copy link
Contributor Author

tkelman commented Jun 24, 2017

I think the branch restrictions apply equally to the merge button on PR's vs pushing from the command line. From what I've seen there's no github feature that does exactly what we want of enforcing master should only be pushable via PR's.

@KristofferC KristofferC merged commit 2c93acf into master Jun 24, 2017
@KristofferC KristofferC deleted the tk/fixcodegentest branch June 24, 2017 15:58
DrTodd13 pushed a commit to IntelLabs/julia that referenced this pull request Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants