Skip to content

Commit

Permalink
disable #22425 codegen tests when running with coverage flags
Browse files Browse the repository at this point in the history
  • Loading branch information
vtjnash committed Jun 23, 2017
1 parent 5176ded commit 0737032
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions test/codegen.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# tests for codegen and optimizations

const opt_level = Base.JLOptions().opt_level
const coverage = Base.JLOptions().code_coverage || Base.JLOptions().malloc_log

This comment has been minimized.

Copy link
@tkelman

tkelman Jun 24, 2017

Contributor

This is broken (fix in #22506). Don't push straight to master.

const Iptr = sizeof(Int) == 8 ? "i64" : "i32"

# `_dump_function` might be more efficient but it doesn't really matter here...
Expand All @@ -28,7 +29,7 @@ function test_loads_no_call(ir, load_types)
end
@test !contains(line, " call ")
load_split = split(line, " load ", limit=2)
if length(load_split) >= 2
if !coverage && length(load_split) >= 2
@test load_idx <= length(load_types)
if load_idx <= length(load_types)
@test startswith(load_split[2], "$(load_types[load_idx]),")
Expand All @@ -39,7 +40,9 @@ function test_loads_no_call(ir, load_types)
break
end
end
@test load_idx == length(load_types) + 1
if !coverage
@test load_idx == length(load_types) + 1
end
end
if opt_level > 0
# Make sure `jl_string_ptr` is inlined
Expand Down

0 comments on commit 0737032

Please sign in to comment.