add PR number to and touch up NEWS.md entry for #18754 #21842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
May 13, 2017
|
|
||
| * All Intrinsics are now Builtin functions instead and have proper error checking | ||
| and fall-back static compilation support. | ||
| * All `Intrinsics` are now `Builtin` functions instead and have proper error checking |
There was a problem hiding this comment.
I don't think these have code meanings, should maybe just be not capitalized
There was a problem hiding this comment.
Removed quoting and capitalization. Thanks!
There was a problem hiding this comment.
oh they exist in Core, but are very sparsely documented in the devdocs
There was a problem hiding this comment.
Quoting and capitalization restored. How now? :)
There was a problem hiding this comment.
pretty sure the module name is plural
tkelman
reviewed
May 13, 2017
NEWS.md
Outdated
| @@ -584,3 +585,4 @@ Deprecated or removed | |||
| [#20543]: https://github.com/JuliaLang/julia/issues/20543 | |||
| [#20609]: https://github.com/JuliaLang/julia/issues/20609 | |||
| [#20889]: https://github.com/JuliaLang/julia/issues/20889 | |||
| [#21359]: https://github.com/JuliaLang/julia/issues/21359 | |||
There was a problem hiding this comment.
this part of the diff shouldn't be backported
There was a problem hiding this comment.
Good catch! I stripped this line from the diff here and elsewhere. I will strip this line from any future commits as well. Thanks!
Sacha0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #21475. Best!