Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure NEWS.md lists all 0.6 deprecations and breaking changes #21475

Closed
tkelman opened this issue Apr 21, 2017 · 9 comments · Fixed by #22329
Closed

Make sure NEWS.md lists all 0.6 deprecations and breaking changes #21475

tkelman opened this issue Apr 21, 2017 · 9 comments · Fixed by #22329
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Milestone

Comments

@tkelman
Copy link
Contributor

tkelman commented Apr 21, 2017

Reviewing the checklist I had in #17418 for the 0.5 release, pretty much the only thing we're missing for an 0.6 RC (other than #21470) is doing a final pass over NEWS.md and making sure all the deprecations and breaking changes that should be listed there are.

Check https://github.com/JuliaLang/julia/issues?utf8=%E2%9C%93&q=label%3Anews and https://github.com/JuliaLang/julia/issues?utf8=%E2%9C%93&q=label%3Adeprecation and https://github.com/JuliaLang/julia/blob/release-0.6/base/deprecated.jl#L117-L1325, make sure everything is listed.

@tkelman tkelman added needs news A NEWS entry is required for this change help wanted Indicates that a maintainer wants help on an issue or pull request labels Apr 21, 2017
@tkelman tkelman added this to the 0.6.0 milestone Apr 21, 2017
@StefanKarpinski
Copy link
Member

@Sacha0, you rock! Thank you for writing news for so many changes (especially so many of mine).

@Sacha0
Copy link
Member

Sacha0 commented May 12, 2017

My pleasure, thank you for the kind words, and thank you for reviewing! :)

@Sacha0
Copy link
Member

Sacha0 commented May 12, 2017

I culled the set of closed pull requests labeled news to those still absent from NEWS.md. The following such pull requests remain in need of attention:

@tkelman
Copy link
Contributor Author

tkelman commented May 12, 2017

we should maybe rename the label to needs-news then if we're going to use it as a state tracker and remove it once added

@tkelman
Copy link
Contributor Author

tkelman commented May 13, 2017

#17439 was 0.5, #12807 is 0.7

@Sacha0
Copy link
Member

Sacha0 commented May 13, 2017

#17439 was 0.5, #12807 is 0.7

Updated --- thanks! :)

This was referenced May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants