Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate GitAnyObject -> GitUnknownObject #19935

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Deprecate GitAnyObject -> GitUnknownObject #19935

merged 2 commits into from
Jan 9, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jan 8, 2017 •
edited
Loading

As part of #19839. Thanks to @ararslan for helping me debug this one (:wink:).

@kshyatt kshyatt added the libgit2 The libgit2 library or the LibGit2 stdlib module label Jan 8, 2017
@kshyatt kshyatt requested a review from simonbyrne January 8, 2017 21:58
@kshyatt kshyatt added the deprecation This change introduces or involves a deprecation label Jan 8, 2017
simonbyrne
simonbyrne reviewed Jan 8, 2017
View reviewed changes
base/libgit2/consts.jl
@@ -7,12 +7,12 @@ module Consts
const REMOTE_ORIGIN = "origin"

# objs
const OBJ_ANY = Cint(-2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep this the same, as the name comes from the header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, i'll leave a comment somewhere to that effect

simonbyrne
simonbyrne reviewed Jan 9, 2017
View reviewed changes
Copy link
Contributor

@simonbyrne simonbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonbyrne simonbyrne mentioned this pull request Jan 9, 2017
Open
42 tasks
@simonbyrne simonbyrne merged commit ade8097 into master Jan 9, 2017
@simonbyrne simonbyrne deleted the ksh/anyunknown branch January 9, 2017 14:42
@Sacha0 Sacha0 added the needs news A NEWS entry is required for this change label May 13, 2017
@Sacha0 Sacha0 mentioned this pull request May 13, 2017
Closed
@KristofferC KristofferC removed the needs news A NEWS entry is required for this change label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne left review comments

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshyatt @simonbyrne @KristofferC @Sacha0