Fix stack overflow in SSHCredentials constructor #21779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
backport pending 0.6
bugfix
kshyatt
reviewed
May 10, 2017
test/libgit2.jl
Outdated
| @testset "Issue #21775" begin | ||
| okay = true | ||
| try | ||
| cred = LibGit2.SSHCredentials("rick", "astley") |
omus
requested changes
May 10, 2017
test/libgit2.jl
Outdated
| finally | ||
| @test okay | ||
| end | ||
| end |
There was a problem hiding this comment.
I'm not sure we need to explicitly be testing for a StackOverflow. Maybe just a basic test which uses this constructor should be added into the "Credentials" testset?
There was a problem hiding this comment.
Good idea. I was just being lazy here. Implemented your suggestion. Thanks!
|
64-bit AV failure is unrelated |
omus
approved these changes
May 11, 2017
tkelman
pushed a commit
that referenced
this pull request
May 14, 2017
(cherry picked from commit 1129de3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21775