Fix stack overflow in SSHCredentials constructor (#21779)

JuliaLang · May 11, 2017 · 1129de3 · 1129de3
1 parent df443c1
commit 1129de3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/base/libgit2/types.jl b/base/libgit2/types.jl
@@ -699,7 +699,7 @@ mutable struct SSHCredentials <: AbstractCredentials
         finalizer(c, securezero!)
         return c
     end
-    SSHCredentials(u::AbstractString,p::AbstractString,prompt_if_incorrect::Bool=false) = SSHCredentials(u,p,prompt_if_incorrect)
+    SSHCredentials(u::AbstractString,p::AbstractString,prompt_if_incorrect::Bool=false) = SSHCredentials(u,p,"","",prompt_if_incorrect)
     SSHCredentials(prompt_if_incorrect::Bool=false) = SSHCredentials("","","","",prompt_if_incorrect)
 end
 

diff --git a/test/libgit2.jl b/test/libgit2.jl
@@ -1249,6 +1249,11 @@ mktempdir() do dir
         @test LibGit2.checkused!(creds)
         @test creds.user == creds_user
         @test creds.pass == creds_pass
+        sshcreds = LibGit2.SSHCredentials(creds_user, creds_pass)
+        @test sshcreds.user == creds_user
+        @test sshcreds.pass == creds_pass
+        @test isempty(sshcreds.prvkey)
+        @test isempty(sshcreds.pubkey)
     end
 
     # The following tests require that we can fake a TTY so that we can provide passwords