Fix bug in backsolve of sparse hermitian matrices #21165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any computational tests that would distinguish the Hermitian branch from LU? |
In theory, it might be possible because the LU branch is a bit more numerically stable but I think the benchmark route is more reliable. Let's try to run the sparse benchmarks when JuliaCI/BaseBenchmarks.jl#68 has been merged. |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
Closed
tkelman
pushed a commit
that referenced
this pull request
May 3, 2017
(cherry picked from commit 9baadbf)
tkelman
pushed a commit
that referenced
this pull request
May 3, 2017
(cherry picked from commit 9baadbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will addAdded a benchmark to BaseBenchmarks too.cc: @andreasnoack