Benchmark for backsolve of sparse hermitian matrices #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
requested changes
Mar 28, 2017
src/sparse/SparseBenchmarks.jl
Outdated
| A = sprand(10^4, 10^4, 1e-4) | ||
| A = A + A' + speye(10^4) | ||
| @assert ishermitian(A) | ||
| b = rand(10^4) |
There was a problem hiding this comment.
Can you use BaseBenchmark.RandUtils to construct these arrays instead of calling an unseeded rand/srand?
src/sparse/SparseBenchmarks.jl
Outdated
| # Backsolve # | ||
| ############# | ||
|
|
||
| g = addgroup!(SUITE, "backsolve") |
There was a problem hiding this comment.
Instead of adding a new benchmark group here, it probably makes sense to just add this to the group where backsolve is normally tested, which you can do by following a pattern similar to here.
* Use BaseBenchmarks random number generation * Add benchmark to Linalg arithmetic
|
@jrevels is this okay now? |
jrevels
approved these changes
Mar 30, 2017
|
I'll kick off the tuning process now, and comment here when it's done. |
|
This benchmark should now be available via Nanosoldier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref JuliaLang/julia#21165