Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against broadcast!(identity, A, B) regressions #20182

Closed
wants to merge 1 commit into from

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jan 22, 2017

This pull request adds tests guarding against regression of broadcast!(identity, A::AbstractArray, B::AbstractArray) where A and B have different shapes. Ref. #19895. Best!

@Sacha0 Sacha0 added test This change adds or pertains to unit tests broadcast Applying a function over a collection labels Jan 22, 2017
…rray, B::AbsArray) where A and B have different shapes.
@Sacha0
Copy link
Member Author

Sacha0 commented Jan 25, 2017

(Whitespace issue fixed, added another test.)

@Sacha0
Copy link
Member Author

Sacha0 commented Jan 25, 2017

Closing in favor of #20227. Best!

@Sacha0 Sacha0 closed this Jan 25, 2017
@Sacha0 Sacha0 deleted the testidentbc branch January 25, 2017 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant