Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add broadcast!{S,T,N}(identity, A::Array{S,N}, B::Array{T,N}) specialization calling memcpy #20227

Closed
Sacha0 opened this issue Jan 25, 2017 · 2 comments
Closed

Add broadcast!{S,T,N}(identity, A::Array{S,N}, B::Array{T,N}) specialization calling memcpy #20227

Sacha0 opened this issue Jan 25, 2017 · 2 comments
Labels
broadcast Applying a function over a collection performance Must go faster

Comments

@Sacha0
Copy link
Member

Sacha0 commented Jan 25, 2017

#19895 removed an (incorrect and ambiguity-causing) broadcast! specialization (roughly broadcast!{S,T,N}(identity, A::AbstractArray{S,N}, B::AbstractArray{T,N}) = copy!(A, B)). Restoring a narrower, corrected form of that specialization for Arrays might be worthwhile; see discussion towards the end of #19895. @martinholters sketched an implementation here. (@martinholters, do you plan to wrap that into a PR, or should we mark this up for grabs?) Best!
@Sacha0 Sacha0 added performance Must go faster broadcast Applying a function over a collection labels Jan 25, 2017
@Sacha0 Sacha0 mentioned this issue Jan 25, 2017
Merged
@martinholters
Copy link
Member

martinholters commented Jan 25, 2017 •
edited
Loading

Will make a PR shortly. Objections if I steal the commit from #20182 and include it to have the specialization and its tests in one PR?

Edit: PR at #20234

@martinholters martinholters mentioned this issue Jan 25, 2017
Merged
@Sacha0
Copy link
Member Author

Sacha0 commented Jan 25, 2017

Objections if I steal the commit from #20182 and include it to have the specialization and its tests in one PR?

Please do! And please feel welcome to squash the commit from #20182 into the other test commit, no need to preserve authorship. Best!

@Sacha0 Sacha0 mentioned this issue Jan 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broadcast Applying a function over a collection performance Must go faster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sacha0 @martinholters