fix ability to use .. as an infix operator #19732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkelman, I'm guessing the |
|
Yeah, I believe that's what #19590 is WIP trying to fix. |
stevengj
added
the
regression
| @@ -863,3 +863,6 @@ end | |||
|
|
|||
| @test QualifiedStringMacro.SubModule.x"" === 1 | |||
| @test QualifiedStringMacro.SubModule.y`` === 2 | |||
|
|
|||
| ..(x,y) = x + y | |||
There was a problem hiding this comment.
I would use let ..(x,y) = x+y ..., or just test the result of parse rather than execute the definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @tkelman, the ability to define
..as an infix operator was accidentally removed in #17623. This restores that capability, and adds a test.