fix mach spawn fail interrupt #19590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Dec 14, 2016
| @@ -1,2 +1,2 @@ | |||
| LIBUV_BRANCH=julia-uv1.9.0 | |||
| LIBUV_SHA1=8d5131b6c1595920dd30644cd1435b4f344b46c8 | |||
| LIBUV_SHA1=52d72a52cc7ccd570929990f010ed16e2ec604c | |||
There was a problem hiding this comment.
why a partial sha? 52d72a52cc7ccd570929990f010ed16e2ec604c8
yuyichao
approved these changes
Dec 14, 2016
| jl_sigsetset(&sset); | ||
| while (1) { | ||
| profile = 0; | ||
| sigwait(&sset, &sig); | ||
| sig = 0; | ||
| errno = 0; |
There was a problem hiding this comment.
This one shouldn't be necessary? Or is this just to help future debugging?
vtjnash
force-pushed
the
jn/fix-mach-spawn-fail-interrupt
branch
3 times, most recently
from
67cde87 to
15882bc
Compare
vtjnash
force-pushed
the
jn/fix-mach-spawn-fail-interrupt
branch
from
15882bc to
713dfad
Compare
tkelman
reviewed
Jan 3, 2017
| @@ -0,0 +1 @@ | |||
| 0e6ec181c8bfd322a17dbd843b2b8ebb | |||
There was a problem hiding this comment.
filenames are missing the last char
vtjnash
force-pushed
the
jn/fix-mach-spawn-fail-interrupt
branch
from
713dfad to
673174b
Compare
vtjnash
force-pushed
the
jn/fix-mach-spawn-fail-interrupt
branch
2 times, most recently
from
0c50ccc to
af62111
Compare
This reverts commit 64aa72d.
this uses a nonstandard feature of sleep, but seems to be supported on the major systems if we want to run this test on busybox, we could use its usleep command using a smaller value for sleep lets us test more iterations, which is where the issues usually start to appear
this was a bug in our libuv fork triggering a bug in the mach kernel code must be careful to never use sigprocmask, setjmp, longjmp, or similar such thread-unsafe functions to avoid this documented unspecified behavior
vtjnash
force-pushed
the
jn/fix-mach-spawn-fail-interrupt
branch
from
af62111 to
e941142
Compare
tkelman
suggested changes
Jan 10, 2017
| @@ -102,7 +102,7 @@ script: | |||
| # capture the log, but only print it if `make deps` fails | |||
| # try to show the end of the log first, because this log might be very long (> 4MB) | |||
| # and thus be truncated by travis | |||
| - moreutils/mispipe "make $BUILDOPTS NO_GIT=1 -C deps 2> deps-err.log" "$BAR" > deps.log || | |||
| - moreutils/mispipe "make \$BUILDOPTS NO_GIT=1 -C deps 2> deps-err.log" "$BAR" > deps.log || | |||
There was a problem hiding this comment.
Please do not merge this unless you've verified that this branch builds from a completely clean cache. The deps should not need the spawn modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should fix the occasional failure we've seen this past year on the spawn test on macOS where it gets a spurious InterruptException generated by the mach kernel. I guess that's what the man page meant when it said this function could have "unspecified behavior".