Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #18408, closure lowering of captured, never-assigned locals #18493

Merged
merged 1 commit into from
Sep 16, 2016
Merged

fix #18408, closure lowering of captured, never-assigned locals #18493

merged 1 commit into from
Sep 16, 2016

Conversation

JeffBezanson
Copy link
Member

No description provided.

@kshyatt kshyatt added compiler:codegen Generation of LLVM IR and native code bugfix This change fixes an existing bug labels Sep 13, 2016
@vtjnash vtjnash merged commit a8bdc2e into master Sep 16, 2016
@vtjnash vtjnash deleted the jb/fix18408 branch September 16, 2016 04:22
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2016

how important is this? can it wait until 0.5.1?

@tkelman tkelman added this to the 0.5.x milestone Sep 16, 2016
@JeffBezanson
Copy link
Member Author

JeffBezanson commented Sep 16, 2016 via email

tkelman referenced this pull request Sep 17, 2016
@tkelman
Add an LLVM patch to fix the windows build breakage from #18490 (#18538)
3a31155 
create DestSharedLibDir in the LLVM Makefile
tkelman pushed a commit that referenced this pull request Feb 22, 2017
@JeffBezanson @tkelman
fix #18408, closure lowering of captured, never-assigned locals
f32c0ed 
(cherry picked from commit 6f69ea9)
ref #18493
@tkelman tkelman mentioned this pull request Mar 2, 2017
Merged
tkelman added a commit that referenced this pull request Mar 3, 2017
@tkelman
Revert "fix #18408, closure lowering of captured, never-assigned locals"
a8fbf31 
This reverts commit f32c0ed.
un-backports #18493, since it caused package regressions in
ASTInterpreter, FixedSizeArrays, GeometryTypes, and QuantumOptics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Milestone
0.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @tkelman @vtjnash @nanosoldier @kshyatt