-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
create DestSharedLibDir in the LLVM Makefile
- Loading branch information
Showing
2 changed files
with
15 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
diff --git a/Makefile.rules b/Makefile.rules | ||
index 24cac3b..4f52dbb 100644 | ||
--- a/Makefile.rules | ||
+++ b/Makefile.rules | ||
@@ -1234,6 +1234,9 @@ endif | ||
DestSharedLib := $(DestSharedLibDir)/$(BaseLibName.SO) | ||
DestSharedAlias := $(DestSharedLibDir)/$(BaseAliasName.SO) | ||
|
||
+$(DestSharedLibDir):: | ||
+ $(MKDIR) $(DestSharedLibDir) | ||
+ | ||
install-local:: $(DestSharedLib) | ||
|
||
$(DestSharedLib): $(LibName.SO) $(DestSharedLibDir) |
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily benchmark build, I will reply here when finished:
@nanosoldier
runbenchmarks(ALL, isdaily = true)
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nanosoldier indicates widespread memory regressions?
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Most likely #18520 or #18493 or #18467 ?
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkelman I don't think #18467 is the cause of most of these regressions. Could be the other two; #18493 is just lowering, so it's unlikely. #18520 affects codegen and is more likely. It might also be #18519.
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#18519 should be a no op on llvm < 4
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't really have spare cycles to bisect this right now but this is more likely caused by lowering and type inference rather than codegen. #18520 should also only affect debug info and coverage.
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can make nanosoldier approximately bisect for us by triggering a bunch of builds against whatever commit the previous nightly build ran on
3a31155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the cause of this been bisected yet?