[release-0.5] backports for 0.5.0-rc3 #18156
Conversation
This mostly reverts #17906 and puts #15521 back in place, but from a slightly more permanent download location now. Unfortunately using the latest opensuse copy of the gcc dll's is causing issues when a cygwin-built Julia tries to load an opensuse-built libzmq.dll. Using these slightly old gcc 5 versions seems to fix it. I suspect the difference is which libstdc++ ABI is being used. GCC 5 has both old and new available, but many distros had it using the old ABI by default for compatibility. GCC 6 (which opensuse is using now) is more likely to be using the new ABI by default. (cherry picked from commit 477a026) ref #18059
some of the spawn and cmdlineargs tests may fail in a no-GPL Windows build if executed outside of the build environment (all of which are GPL themselves...), we could either skip them or try to get them to work via calling powershell or some other non-GPL coreutils replacement (toybox? uutils? sbase + now-LPGL cygwin?) (cherry picked from commit 2a9dd3b) ref #17851
* Replace a malformed link in `write` docstring with a literal `write` rather than
a real cross-reference, since that would just cross-reference itself. Also move
`write` docstring inline.
* Remove cross-reference for `<<` from inside a literal since text inside a literal
can't contain a link. A cross-reference to `<<` already appears at the end of the
docstring.
(cherry picked from commit 2301c27)
ref #17969
* fix a typo in Base.split * fixup! fix a typo in Base.split (cherry picked from commit 75e88af)
This fixes a performance regression in the lucompletepiv benchmark triggered by generalizing _array_for to work with indices. This call, first introduced in b363cc7, likely always triggered dynamic method dispatch. The generalization to indices seemed to make that worse. (cherry picked from commit cb623f8) ref #18009
(cherry picked from commit 1d49ec0)
|
@nanosoldier (now obsolete) |
tkelman
force-pushed
the
tk/backports-0.5.0-rc3
branch
from
fd14be9 to
f8fada1
Compare
|
Instead of reverting the DFT change, can you cherry pick #18178? |
tkelman
force-pushed
the
tk/backports-0.5.0-rc3
branch
from
f8fada1 to
2406ed9
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
As for KrylovMethods: I could not reproduce the issue on my machine and I've changed the test. Previously the direction was chosen randomly (which caused the test to fail sometimes). Now, it is fixed and should always work. |
…ables"" This reverts commit d45bcae.
|
@nanosoldier @JeffBezanson are you going to merge #18046 ? |
|
Merged. |
|
At 2406ed9 we only had the known exception type change with BandedMatrices, and a tolerances-too-tight random failure in PolynomialRoots: https://gist.github.com/08599e229e722ec059f90a17ea5259fc I'm hoping that #18183 won't have any unintended consequences. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
|
Is there an explanation for the performance degration in the BitArray tests? |
|
Probably #18046? |
|
ca5c823 it's in there |
|
Seems like it didn't completely fix the problem then (using Gadfly master) because: |
|
How's master? Worth a new issue probably? |
|
Testing right now. New issue here: GiovineItalia/Gadfly.jl#880. I'll open one against Base once we figure out what's wrong. |
…0.5.0-rc3 [release-0.5] backports for 0.5.0-rc3
@nanosoldier
runbenchmarks(ALL, vs = "@0350e5769b43f56c4c570741b0f5b2edf9399dc7")(vs rc2 tag)will be running pkgeval here to check for any regressions