Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve correctness of fieldtype_tfunc #17953

Merged
merged 1 commit into from
Aug 11, 2016
Merged

improve correctness of fieldtype_tfunc #17953

merged 1 commit into from
Aug 11, 2016

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Aug 10, 2016

it should trust the return value 'exact' that was meticulously computed for getfield_tfunc,
instead of trying to recompute it (badly)

also make getfield_tfunc monotonic for the case where the type has one field

fix #16530

Vararg is only exact if in covariant position

also make getfield_tfunc monotonic for the case where the type has one
field, to avoid the same bug

fix #16530
@JeffBezanson JeffBezanson added backport pending 0.5 bugfix This change fixes an existing bug compiler:inference Type inference labels Aug 11, 2016
@JeffBezanson JeffBezanson merged commit e291b0d into master Aug 11, 2016
@tkelman tkelman deleted the jn/16530 branch August 12, 2016 00:41
vtjnash added a commit that referenced this pull request Aug 16, 2016
the getfield_tfunc was missing a test for whether
the fields were all equivalent before concluding
that the result type was exact

fixes the fix #17953
fix #18037
vtjnash added a commit that referenced this pull request Aug 16, 2016
the getfield_tfunc was missing a test for whether
the fields were all equivalent before concluding
that the result type was exact

fixes the fix #17953
fix #18037
tkelman pushed a commit that referenced this pull request Aug 20, 2016
Vararg is only exact if in covariant position

also make getfield_tfunc monotonic for the case where the type has one
field, to avoid the same bug

fix #16530

(cherry picked from commit aeaff55)
ref #17953
tkelman pushed a commit that referenced this pull request Aug 20, 2016
the getfield_tfunc was missing a test for whether
the fields were all equivalent before concluding
that the result type was exact

fixes the fix #17953
fix #18037

(cherry picked from commit 06a8d89)
ref #18045
mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
the getfield_tfunc was missing a test for whether
the fields were all equivalent before concluding
that the result type was exact

fixes the fix JuliaLang#17953
fix JuliaLang#18037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird type inference(?) behavior with a type unstable creation of a type wrapping a vector of tuples.
3 participants