Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: make which(str) return the path to the command #13197

Closed
wants to merge 3 commits into from
Closed

WIP: make which(str) return the path to the command #13197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbafdb5
make which(str) return the path to the command
bicycle1885 Sep 18, 2015
05bac1d
test on a random command
bicycle1885 Sep 23, 2015
cacea23
check if PATH exists in ENV
bicycle1885 Sep 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions base/file.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,25 @@ function mktempdir(parent=tempdir())
systemerror(:mktempdir, p == C_NULL)
return bytestring(p)
end

# Find and return the path to a command.
function which(cmd::AbstractString)
if !isempty(dirname(cmd))
# `cmd` seems to be a relative path
if isfile(cmd)
return Nullable(utf8(cmd))
end
elseif haskey(ENV, "PATH")
# find `cmd` from the PATH
for path in split(ENV["PATH"], ':')
cmd_path = joinpath(path, cmd)
if isfile(cmd_path)
return Nullable(utf8(cmd_path))
end
end
end
return Nullable{UTF8String}()
end
end

@windows_only begin
Expand Down
4 changes: 4 additions & 0 deletions test/file.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ end
cd(pwd_)
end

# which (TODO: tests for Windows)
@unix_only @test !isnull(which("ls"))
@unix_only @test isfile(get(which("ls")))
@unix_only @test isnull(which("WhayXUbWtIo50h0"))

#######################################################################
# This section tests some of the features of the stat-based file info #
Expand Down