WIP: make which(str) return the path to the command #13197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No comments? 😢 |
| # which (TODO: tests for Windows) | ||
| @unix_only @test !isnull(which("ls")) | ||
| @unix_only @test isfile(get(which("ls"))) | ||
| @unix_only @test isnull(which("abracadabra")) |
There was a problem hiding this comment.
It might be OK for tests to fail if ls isn't on the path, but failing if abracadabra is on the path seems kind of wrong. You should find a more random non-existant path. Might I suggest something like vyqMEOu1xfKCePhtZro7NUKbDmOEtx5ZmVGfUH?
|
Note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
which(cmd::AbstractString)return the path to the command string:This method is useful to find the location of a command and to check if a command exists or not.
The same function is available in the
shutilmodule on Python3 (https://docs.python.org/dev/library/shutil.html#shutil.which).Before going into the details, I'd like to know whether you like it or not.
Nullablegood?