Precompile: Add precomp to Pkg.test

src/API.jl

@@ -141,7 +141,7 @@ for f in (:develop, :add, :rm, :up, :pin, :free, :test, :build, :status)
             Registry.download_default_registries(DEFAULT_IO[])
             ctx = Context()
             ret = $f(ctx, pkgs; kwargs...)
-            $(f in (:add, :up, :pin, :free, :build)) && _auto_precompile(ctx)
+            $(f in (:add, :up, :pin, :free, :build)) && Pkg._auto_precompile(ctx)
             return ret
         end
         $f(ctx::Context; kwargs...) = $f(ctx, PackageSpec[]; kwargs...)
@@ -967,12 +967,6 @@ function _is_stale(paths::Vector{String}, sourcepath::String)
     return true
 end
 
-function _auto_precompile(ctx::Context)
-    if parse(Int, get(ENV, "JULIA_PKG_PRECOMPILE_AUTO", "1")) == 1
-        Pkg.precompile(ctx; internal_call=true)
-    end
-end
-
 function make_pkgspec(man, uuid)
     pkgent = man[uuid]
     # If we have an unusual situation such as an un-versioned package (like an stdlib that
@@ -1372,7 +1366,7 @@ function instantiate(ctx::Context; manifest::Union{Bool, Nothing}=nothing,
     Operations.download_artifacts([dirname(ctx.env.manifest_file)]; platform=platform, verbose=verbose)
     # check if all source code and artifacts are downloaded to exit early
     if Operations.is_instantiated(ctx.env)
-        allow_autoprecomp && _auto_precompile(ctx)
+        allow_autoprecomp && Pkg._auto_precompile(ctx)
         return
     end
 
@@ -1427,7 +1421,7 @@ function instantiate(ctx::Context; manifest::Union{Bool, Nothing}=nothing,
     # Run build scripts
     Operations.build_versions(ctx, union(UUID[pkg.uuid for pkg in new_apply], new_git); verbose=verbose)
 
-    allow_autoprecomp && _auto_precompile(ctx; kwargs...)
+    allow_autoprecomp && Pkg._auto_precompile(ctx; kwargs...)
 end
 
 

src/Operations.jl

@@ -925,7 +925,7 @@ function build_versions(ctx::Context, uuids::Vector{UUID}; verbose=false)
 
         fancyprint && show_progress(ctx.io, bar)
 
-        sandbox(ctx, pkg, source_path, builddir(source_path), build_project_override) do
+        sandbox(ctx, pkg, source_path, builddir(source_path), build_project_override, false) do
             flush(stdout)
             ok = open(log_file, "w") do log
                 std = verbose ? ctx.io : log
@@ -1389,7 +1389,7 @@ end
 
 # ctx + pkg used to compute parent dep graph
 function sandbox(fn::Function, ctx::Context, target::PackageSpec, target_path::String,
-                 sandbox_path::String, sandbox_project_override)
+                 sandbox_path::String, sandbox_project_override, allow_autoprecomp::Bool)
     active_manifest = manifestfile_path(dirname(ctx.env.project_file))
     sandbox_project = projectfile_path(sandbox_path)
 
@@ -1429,6 +1429,7 @@ function sandbox(fn::Function, ctx::Context, target::PackageSpec, target_path::S
         # sandbox
         with_temp_env(tmp) do
             temp_ctx = Context()
+            original_io = ctx.io
             temp_ctx.env.project.deps[target.name] = target.uuid
 
             try
@@ -1451,6 +1452,9 @@ function sandbox(fn::Function, ctx::Context, target::PackageSpec, target_path::S
             end
             write_env(temp_ctx.env, update_undo = false)
 
+            temp_ctx.io = original_io # restore given resolve step suppresses io
+            allow_autoprecomp && Pkg._auto_precompile(temp_ctx)
+
             # Run sandboxed code
             path_sep = Sys.iswindows() ? ';' : ':'
             withenv(fn, "JULIA_LOAD_PATH" => "@$(path_sep)$(tmp)", "JULIA_PROJECT" => nothing)
@@ -1532,8 +1536,8 @@ testdir(source_path::String) = joinpath(source_path, "test")
 testfile(source_path::String) = joinpath(testdir(source_path), "runtests.jl")
 function test(ctx::Context, pkgs::Vector{PackageSpec};
               coverage=false, julia_args::Cmd=``, test_args::Cmd=``,
-              test_fn=nothing)
-    Pkg.instantiate(ctx; allow_autoprecomp = false)
+              test_fn=nothing, allow_autoprecomp::Bool=true)
+    Pkg.instantiate(ctx; allow_autoprecomp = false) # do precomp later within sandbox
 
     # load manifest data
     for pkg in pkgs
@@ -1568,7 +1572,7 @@ function test(ctx::Context, pkgs::Vector{PackageSpec};
             gen_target_project(ctx.env, ctx.registries, pkg, source_path, "test")
         # now we sandbox
         printpkgstyle(ctx.io, :Testing, pkg.name)
-        sandbox(ctx, pkg, source_path, testdir(source_path), test_project_override) do
+        sandbox(ctx, pkg, source_path, testdir(source_path), test_project_override, allow_autoprecomp) do
             test_fn !== nothing && test_fn()
             status(Context(); mode=PKGMODE_COMBINED)
             printpkgstyle(ctx.io, :Testing, "Running tests...")

src/Pkg.jl

@@ -186,6 +186,7 @@ const update = API.up
   - `coverage::Bool=false`: enable or disable generation of coverage statistics.
   - `julia_args::Union{Cmd, Vector{String}}`: options to be passed the test process.
   - `test_args::Union{Cmd, Vector{String}}`: test arguments (`ARGS`) available in the test process.
+  - `allow_autoprecomp::Bool=true`: allow auto-precompilation to be done in test environment, if not disabled globally
 
 !!! compat "Julia 1.3"
     `julia_args` and `test_args` requires at least Julia 1.3.
@@ -596,6 +597,12 @@ end
 # Precompilation #
 ##################
 
+function _auto_precompile(ctx::Types.Context)
+    if parse(Int, get(ENV, "JULIA_PKG_PRECOMPILE_AUTO", "1")) == 1
+        Pkg.precompile(ctx; internal_call=true)
+    end
+end
+
 using LibGit2: LibGit2
 function _run_precompilation_script_setup()
     tmp = mktempdir()