Precompile: Add precomp to Pkg.test #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
IanButterworth
changed the title
allow_autoprecomp kwarg to Pkg.test to allow Pkg.precompile in test sandbox, which defaults to true
IanButterworth
commented
Jan 14, 2021
|
Working and printing locally now |
|
Can I get approval on this? |
fredrikekre
approved these changes
Jan 15, 2021
|
@fredrikekre I realized that the precomp was happening before the status print.. which would make debugging package failure during the precomp stage much harder. It's now after the status print |
IanButterworth
added a commit
to IanButterworth/Pkg.jl
that referenced
this pull request
Jan 15, 2021
* add option for `Pkg.test` to allow `Pkg.precompile` in test sandbox * fix access to _auto_precompile * restore IO after devnull * make ENV read safe * remove kwarg and move precomp to after status * rm kwarg from docstring (cherry picked from commit fe759b2)
IanButterworth
added a commit
that referenced
this pull request
Jan 15, 2021
* add option for `Pkg.test` to allow `Pkg.precompile` in test sandbox * fix access to _auto_precompile * restore IO after devnull * make ENV read safe * remove kwarg and move precomp to after status * rm kwarg from docstring (cherry picked from commit fe759b2)
maleadt
added a commit
to JuliaCI/julia-test-buildkite-plugin
that referenced
this pull request
Jan 20, 2021
It will happen during Pkg.Test: JuliaLang/Pkg.jl#2335. On older versions of Julia it isn't parallel anyway, so doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-precompilation is currently not run during
Pkg.test, which means if a CI test just relies onPkg.testto install the deps it currently won't benefit from parallel precomp.Now that error reporting in
Pkg.precompilehas improved to properly error and show stacktraces the issues around lack of information that led to it being disabled #2110 should have been cleared.Things to note:
Pkg.test(... allow_autoprecomp = false)orENV["JULIA_PKG_PRECOMPILE_AUTO"]=0, and the kwarg could be exposed by the github action